Spring Managed HST Components support & @Autowired in PageErrorHandler causes several warnings

[dennis.nijssen]

Hi,

In a new Hippo 11.2 project we began to use the Spring Managed HST Components support (https://www.onehippo.org/library/concepts/web-application/spring-managed-hst-components.html). I've added the following components.xml to /META-INF/hst-assembly/overrides/components.xml:

<?xml version="1.0" encoding="UTF-8"?>

<beans xmlns="http://www.springframework.org/schema/beans" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:context="http://www.springframework.org/schema/context"

  xmlns:aop="http://www.springframework.org/schema/aop"

  xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-4.1.xsd

                           http://www.springframework.org/schema/context http://www.springframework.org/schema/context/spring-context-4.1.xsd

                           http://www.springframework.org/schema/aop http://www.springframework.org/schema/aop/spring-aop-4.1.xsd">

  <context:annotation-config />

  <context:component-scan base-package="com.hippocommunity.components" />
  <context:component-scan base-package="com.hippocommunity.services" />

</beans>

The second base-package is where all our services are located. We also use these services in our custom PageErrorHandler, where we autowired one of them:

package com.hippocommunity.errorhandlers;

// SNIP

public class MyPageErrorHandler implements PageErrorHandler {

    @Autowired private LinkCreatorService linkCreatorService;

    // SNIP

}

We have the following bean configured in /META-INF/hst-assembly/overrides/page-error-handler.xml:

<?xml version="1.0" encoding="UTF-8"?>

<beans xmlns="http://www.springframework.org/schema/beans" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"

  xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans-4.1.xsd">

  <bean id="org.hippoecm.hst.core.container.PageErrorHandler" class="com.hippocommunity.errorhandlers.MyPageErrorHandler" />

</beans>

So since the MyPageErrorHandler is a registered bean, and it lives in the same Spring context of Hippo, the LinkCreatorService gets autowired. 

All works fine! Except we are getting the following warning (and several similar ones) 4 times during application start up: 

28.03.2017 11:30:43 WARN  localhost-startStop-1 [AbstractBeanFactory.getTypeForFactoryBean:1485] Bean creation exception on non-lazy FactoryBean type check: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'org.hippoecm.hst.pagecomposer.jaxrs.security.SecurityModel#SecurityModelEventListener' defined in class path resource [org/hippoecm/hst/pagecomposer/SpringComponentManager-pagecomposer.xml]: Cannot resolve reference to bean 'jcrObservationEventListenerItems' while setting bean property 'targetObject'; nested exception is org.springframework.beans.factory.BeanCurrentlyInCreationException: Error creating bean with name 'jcrObservationEventListenerItems': org.springframework.beans.factory.FactoryBeanNotInitializedException: FactoryBean is not fully initialized yet

When we remove the @Autowired from MyPageErrorHandler all, the warnings disappear. But we can't use the dependency injection with our services as we like to.

Is there anything we done wrong or what we can change to prevent these warnings from happening? 

Same issues happen when we add some custom jax-rs plain restservices and use @Autowired there. 

Kind regards,

Dennis

[Woonsan Ko]

I'm not sure, but one possibility is there could be a circular reference unintentionally. [1]

Just as an example, if you have used 'customJcrObservationEventListenerItems' [2] (which is to be merged to 'jcrObservationEventListenerItems' bean in the end internally) and injected it or an inline event listener object inside it to some bean which is scanned automatically by annotation, and if the event listener bean is also using @Autowired, ...

Could you try to rule out one by one to find where that can happen? Considering the warning message, it might be related to custom event listeners... but it's just a guess.

Regards,

Woonsan

[1] http://docs.spring.io/spring/docs/current/javadoc-api/org/springframework/beans/factory/FactoryBeanNotInitializedException.html

[2] https://www.onehippo.org/library/concepts/hst-spring/how-to-add-custom-jcr-event-listener-through-spring-configuration.html

 

Same issues happen when we add some custom jax-rs plain restservices and use @Autowired there. 

Kind regards,

Dennis

--
Hippo Community Group: The place for all discussions and announcements about Hippo CMS (and HST, repository etc. etc.)
 
To post to this group, send email to hippo-community@googlegroups.com
RSS: https://groups.google.com/group/hippo-community/feed/rss_v2_0_msgs.xml?num=50
---
You received this message because you are subscribed to the Google Groups "Hippo Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to hippo-community+unsubscribe@googlegroups.com.
Visit this group at https://groups.google.com/group/hippo-community.
For more options, visit https://groups.google.com/d/optout.

--

woons...@bloomreach.com     www.onehippo.com

71 Summer Street, 2nd Floor, Boston, MA 02110

Amsterdam - Oosteinde 11, 1017 WT Amsterdam
US +1 877 414 4776 (toll free)
Europe +31(0)20 522 4466

[dennis.nijssen]

Hi Woonsan,

I'm indeed thinking there could be a circular dependency, it's just weird that we get no warning at all without the components.xml (that contains the <context:annotation-config /> and several <context:component-scan ..... />) and not trying to autowire anything within the PageErrorHandler and jaxrs resources.

As stated in my previous post, we get several of these warnings, including one in the urlrewriting-context.xml which we copied from here: https://code.onehippo.org/cms-community/hippo-plugin-urlrewriter/blob/master/demo/site/src/main/resources/META-INF/hst-assembly/overrides/urlrewriting-context.xml

When we add depends-on="jcrObservationEventListenerItems" to the MethodInvokingFactoryBean, the warnings disappear in this case.

Then I've also seen a similar message from the SpringComponentManager-rest-plain-pipeline.xml:

27.03.2017 16:15:45 WARN  localhost-startStop-1 [AbstractBeanFactory.getTypeForFactoryBean:1485] Bean creation exception on non-lazy FactoryBean type check: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'org.springframework.beans.factory.config.MethodInvokingFactoryBean#1' defined in class path resource [org/hippoecm/hst/site/optional/jaxrs/SpringComponentManager-rest-plain-pipeline.xml]: Cannot create inner bean 'org.hippoecm.hst.core.container.HstSitePipeline#88be024' of type [org.hippoecm.hst.core.container.HstSitePipeline] while setting bean property 'arguments' with key [1]; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'org.hippoecm.hst.core.container.HstSitePipeline#88be024' defined in class path resource [org/hippoecm/hst/site/optional/jaxrs/SpringComponentManager-rest-plain-pipeline.xml]: Cannot resolve reference to bean 'jaxrsRestPlainServiceValve' while setting bean property 'processingValves' with key [4]; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'jaxrsRestPlainServiceValve' defined in class path resource [org/hippoecm/hst/site/optional/jaxrs/SpringComponentManager-rest-plain-pipeline.xml]: Cannot create inner bean 'org.hippoecm.hst.jaxrs.cxf.CXFJaxrsService#60342df6' of type [org.hippoecm.hst.jaxrs.cxf.CXFJaxrsService] while setting constructor argument; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'org.hippoecm.hst.jaxrs.cxf.CXFJaxrsService#60342df6' defined in class path resource [org/hippoecm/hst/site/optional/jaxrs/SpringComponentManager-rest-plain-pipeline.xml]: Cannot create inner bean 'org.apache.cxf.jaxrs.JAXRSServerFactoryBean#704c3cea' of type [org.apache.cxf.jaxrs.JAXRSServerFactoryBean] while setting bean property 'jaxrsServerFactoryBean'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'org.apache.cxf.jaxrs.JAXRSServerFactoryBean#704c3cea' defined in class path resource [org/hippoecm/hst/site/optional/jaxrs/SpringComponentManager-rest-plain-pipeline.xml]: Cannot resolve reference to bean 'jaxrsRestPlainResourceProviders' while setting bean property 'resourceProviders'; nested exception is org.springframework.beans.factory.BeanCurrentlyInCreationException: Error creating bean with name 'jaxrsRestPlainResourceProviders': org.springframework.beans.factory.FactoryBeanNotInitializedException: FactoryBean is not fully initialized yet

Kind regards,

Dennis

To post to this group, send email to hippo-c...@googlegroups.com

RSS: https://groups.google.com/group/hippo-community/feed/rss_v2_0_msgs.xml?num=50
---
You received this message because you are subscribed to the Google Groups "Hippo Community" group.

To unsubscribe from this group and stop receiving emails from it, send an email to hippo-communi...@googlegroups.com.

Visit this group at https://groups.google.com/group/hippo-community.
For more options, visit https://groups.google.com/d/optout.

[Woonsan Ko]

Hi Dennis,

I've just tried to reproduce it with a simple example in hippo-testsuite project, but it seems working fine without that kind of warnings.

I added this service:

package org.hippoecm.hst.demo.services;

import org.springframework.stereotype.Component;

@Component

public class FooService {

    public String getMessage(String input) {

        return input;

    }

}

And, auto-wired it in Search component:

package org.hippoecm.hst.demo.components;

//...

@Component

@Scope(ConfigurableBeanFactory.SCOPE_PROTOTYPE)

@Service(DemoConstants.COMPONENT_BASE_PACKAGE + ".Search")

public class Search extends AbstractSearchComponent {

    //...

    @Autowired

    private FooService fooService;

    //...

Also, updated components.xml:

    <context:annotation-config />

    <context:component-scan base-package="org.hippoecm.hst.demo.components" />

    <context:component-scan base-package="org.hippoecm.hst.demo.services" />

It doesn't give the warnings on startup and is working fine there.

So, I'm wondering if something in your project could have interfered with any beans of HST container.

Do you have any custom jcr observation event listener as I mentioned before, or do you have any other custom components such as custom valve(s) having annotations in your project?

Regards,

Woonsan

To post to this group, send email to hippo-community@googlegroups.com

RSS: https://groups.google.com/group/hippo-community/feed/rss_v2_0_msgs.xml?num=50
---
You received this message because you are subscribed to the Google Groups "Hippo Community" group.

To unsubscribe from this group and stop receiving emails from it, send an email to hippo-community+unsubscribe@googlegroups.com.

Visit this group at https://groups.google.com/group/hippo-community.
For more options, visit https://groups.google.com/d/optout.

[dennis.nijssen]

Hello Woonsan,

This setup seems to be almost identical. What you are missing when trying to reproduce my problem is: You doesn't seem to have added a custom PageErrorHandler or custom jaxrs resource.

Could you maybe add a custom PageErrorHandler that autowires the FooService aswell, and see if you get any warnings. If not, there might indeed be something wrong at my project. :)

But no, I do not have any custom JCR observation event listeners as you described. I'm only mentioning the jcrObservationEventListenerItems as a targetObject of a MethodInvokingFactoryBean in the urlrewriting-context.xml.

King regards,

Dennis

[Woonsan Ko]

On Tue, Mar 28, 2017 at 12:36 PM, 'dennis.nijssen' via Hippo Community <hippo-c...@googlegroups.com> wrote:

Hello Woonsan,

This setup seems to be almost identical. What you are missing when trying to reproduce my problem is: You doesn't seem to have added a custom PageErrorHandler or custom jaxrs resource.

Could you maybe add a custom PageErrorHandler that autowires the FooService aswell, and see if you get any warnings. If not, there might indeed be something wrong at my project. :)

I've added a custom page error handler bean definition and made the custom page error handler be injected with the FooService. [2]

But it still seems working fine without that kind of warning. I've confirmed that the fooService is referenced correctly through debugger, too.

[1] https://www.onehippo.org/library/concepts/error-pages-and-error-handling/4.-advanced-exception-handling.html

[2] https://code.onehippo.org/cms-community/hippo-testsuite/commit/18d1a39f855a4bc527ab3f01d982b6183946cdef

 

To post to this group, send email to hippo-community@googlegroups.com

RSS: https://groups.google.com/group/hippo-community/feed/rss_v2_0_msgs.xml?num=50
---
You received this message because you are subscribed to the Google Groups "Hippo Community" group.

To unsubscribe from this group and stop receiving emails from it, send an email to hippo-community+unsubscribe@googlegroups.com.

Visit this group at https://groups.google.com/group/hippo-community.
For more options, visit https://groups.google.com/d/optout.

[dennis.nijssen]

I've just created a new archetype project, and added a Component, PageErrorHandler and a FooService aswell.

When I run mvn clean package and mvn -P cargo.run I still get the following warning on startup:

29.03.2017 08:55:53 WARN  localhost-startStop-1 [AbstractBeanFactory.getTypeForFactoryBean:1485] Bean creation exception on non-lazy FactoryBean type check: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'org.hippoecm.hst.pagecomposer.jaxrs.security.SecurityModel#SecurityModelEventListener' defined in class path resource [org/hippoecm/hst/pagecomposer/SpringComponentManager-pagecomposer.xml]: Cannot resolve reference to bean 'jcrObservationEventListenerItems' while setting bean property 'targetObject'; nested exception is org.springframework.beans.factory.BeanCurrentlyInCreationException: Error creating bean with name 'jcrObservationEventListenerItems': org.springframework.beans.factory.FactoryBeanNotInitializedException: FactoryBean is not fully initialized yet

As reference I pushed my code to a public github repository: https://github.com/dnijssen/myhippoproject

Is there anything in the Hippo testsuite that fixed this warning? Or is it cause the testsuite is running on Hippo 12.0 ? 

It is indeed still working correctly, I've also checked with a debugged and the FooService is injected correctly in the Component and PageErrorHandler.

King regards,

Dennis

[Woonsan Ko]

Hi Dennis,

Thank you very much for sharing the github project! It was really helpful!

I was able to see the same warning locally, too. It is indeed a very interesting problem case.

But the good news is, the warning message seems almost harmless to me! :-) So, you can ignore the warning in this context.

Here's my explanation.

- When an applicationContext is initialized, if auto-wiring is used, then for each @Autowired field/property, the AutowiredAnnotationBeanPostProcessor tries to find a *type-matched bean* from the beanFactory.

- In your project, actually the warning occurred while it tries to find a bean of type FooService (a *type-matched bean* by FooService type in this case) for MyPageErrorHandler bean. I found this by attaching debugger at AbstractBeanFactory.getTypeForFactoryBean:1485 literally and looking at the stack trace.

- The way how it determines the best *type-matched bean* is, (1) iterate each bean definition from all the beans registered in the beanFactory, (2) if a bean definition is not a factoryBean, it checks the type directly and put in into a bag or ignore, or if it is a factoryBean, it needs to create a bean from the factoryBean to find out the type exactly, or return null with that kind of warning if the factory cannot create object yet for some reason, c) from the all the candidate beans collected by the type, it finally determines which to take for the @Autowired field/property.

- In your project, during the scanning/determination process, it left some warnings on some of factory beans due to not being ready to create object at the moment, but it found out the proper FooService bean in the end and assign in to the MyPageErrorHandler bean. I confirmed this by expressions in debug session:

-- org.hippoecm.hst.site.HstServices.getComponentManager().getComponent("org.hippoecm.hst.core.container.PageErrorHandler")

-- org.hippoecm.hst.site.HstServices.getComponentManager().getComponent("jcrObservationEventListenerItems ")

- Luckily in this case, the *ignored* (with warning) bean definitions were simply the factory beans to create a java.util.List objects such as 'jcrObservationEventListenerItems'.

Therefore, you can ignore this kind of warning logs if the warning logs are concerning about only factory bean definitions which are out of interest in terms of auto-wiring in your project.

Regards,

Woonsan

To post to this group, send email to hippo-community@googlegroups.com

RSS: https://groups.google.com/group/hippo-community/feed/rss_v2_0_msgs.xml?num=50
---
You received this message because you are subscribed to the Google Groups "Hippo Community" group.

To unsubscribe from this group and stop receiving emails from it, send an email to hippo-community+unsubscribe@googlegroups.com.

Visit this group at https://groups.google.com/group/hippo-community.
For more options, visit https://groups.google.com/d/optout.

[dennis.nijssen]

Thank you for researching this Woonsan, although the conclusion is we can ignore the warnings, isn't it better to prevent them from happening? 

I've seen the same warning happening when adding the urlrewriter plugin. With that particular case I had the urlrewriting-context.xml in my project and was able to add depends-on="jcrObservationEventListenerItems" to the MethodInvokingFactoryBean, This made the warnings disappear. 

I wonder if the same could be done to org/hippoecm/hst/pagecomposer/SpringComponentManager-pagecomposer.xml and org/hippoecm/hst/site/optional/jaxrs/SpringComponentManager-rest-plain-pipeline.xml, these are just two cases where I've seen the problem occur aswell. The warnings can be ignored, but it can also suppress other trivial log messages, also since the messages seems to grow exponentially!

In my case where I've also seen the warning occur from a jaxrs resource, I noticed that the more resources I added, all injecting services (that also inject other spring beans), the amount of warnings grow fast! (And they are all the same..) 

I've added the extra jaxrs resources and services to the github project. See https://github.com/dnijssen/myhippoproject/commit/4207feb71c0bb1f708973c1903a5828dcd49600d

Together with the jaxrs resources, I've also added a MethodInvokingFactoryBean to add a LocatizationValve to the JaxrsRestPlainPipeline (see custom-jaxrs-resources.xml), this causes the following warning:

29.03.2017 21:54:41 WARN  localhost-startStop-1 [AbstractBeanFactory.getTypeForFactoryBean:1485] Bean creation exception on non-lazy FactoryBean type check: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'org.springframework.beans.factory.config.MethodInvokingFactoryBean#3' defined in file [C:\Users\dennisn\Documents\Git\Hippo\myhippoproject\target\tomcat8x\webapps\site\WEB-INF\classes\META-INF\hst-assembly\overrides\custom-jaxrs-resources.xml]: Invocation of init method failed; nested exception is java.lang.IllegalArgumentException: Either 'targetClass' or 'targetObject' is required

What is Hippo's thought on this?

King regards,

Dennis

On Wednesday, March 29, 2017 at 6:51:32 PM UTC+2, woonsan.ko wrote:

Hi Dennis,

Thank you very much for sharing the github project! It was really helpful!

I was able to see the same warning locally, too. It is indeed a very interesting problem case.

But the good news is, the warning message seems almost harmless to me! :-) So, you can ignore the warning in this context.

Here's my explanation.

- When an applicationContext is initialized, if auto-wiring is used, then for each @Autowired field/property, the AutowiredAnnotationBeanPostProcessor tries to find a *type-matched bean* from the beanFactory.

- In your project, actually the warning occurred while it tries to find a bean of type FooService (a *type-matched bean* by FooService type in this case) for MyPageErrorHandler bean. I found this by attaching debugger at AbstractBeanFactory.getTypeForFactoryBean:1485 literally and looking at the stack trace.

- The way how it determines the best *type-matched bean* is, (1) iterate each bean definition from all the beans registered in the beanFactory, (2) if a bean definition is not a factoryBean, it checks the type directly and put in into a bag or ignore, or if it is a factoryBean, it needs to create a bean from the factoryBean to find out the type exactly, or return null with that kind of warning if the factory cannot create object yet for some reason, c) from the all the candidate beans collected by the type, it finally determines which to take for the @Autowired field/property.

- In your project, during the scanning/determination process, it left some warnings on some of factory beans due to not being ready to create object at the moment, but it found out the proper FooService bean in the end and assign in to the MyPageErrorHandler bean. I confirmed this by expressions in debug session:

-- org.hippoecm.hst.site.HstServices.getComponentManager().getComponent("org.hippoecm.hst.core.container.PageErrorHandler")

-- org.hippoecm.hst.site.HstServices.getComponentManager().getComponent("jcrObservationEventListenerItems ")

- Luckily in this case, the *ignored* (with warning) bean definitions were simply the factory beans to create a java.util.List objects such as 'jcrObservationEventListenerItems'.

Therefore, you can ignore this kind of warning logs if the warning logs are concerning about only factory bean definitions which are out of interest in terms of auto-wiring in your project.

Regards,

Woonsan

[Woonsan Ko]

On Wed, Mar 29, 2017 at 4:03 PM, 'dennis.nijssen' via Hippo Community <hippo-c...@googlegroups.com> wrote:

Thank you for researching this Woonsan, although the conclusion is we can ignore the warnings, isn't it better to prevent them from happening? 

I've seen the same warning happening when adding the urlrewriter plugin. With that particular case I had the urlrewriting-context.xml in my project and was able to add depends-on="jcrObservationEventListenerItems" to the MethodInvokingFactoryBean, This made the warnings disappear. 

"depends-on" seems to make it more difficult to maintain the software.

So I have another solution:

- AbstractBeanFactory has a special routine for factory bean: #getTypeForFactoryBean(String, RootBeanDefinition).

- That routine invokes FactoryBean#getObjectType(). So in most cases, it doesn't require the factory bean to create an object only for type checking.

- However, unfortunately, MethodInvokingFactoryBean#getObjectType() was implemented to try to create an object because it is unaware of the type unlike somethings like ListFactoryBean or MapFactoryBean that can safely infer the type is either java.util.List or java.util.Map.

- So, my solution is, maybe HST can extend MethodInvokingFactoryBean to have predetermined type. For example,

[Before]

  <bean class="org.springframework.beans.factory.config.MethodInvokingFactoryBean">

    <property name="targetObject" ref="jcrObservationEventListenerItems"/>

    <property name="targetMethod" value="add"/>

    <!-- SNIP --> 

  </bean>

[After]

  <bean class="org.hippoecm.hst.site.container.ResourceFactoryBean.TypeDeterminedMethodInvokingFactoryBean">

    <property name="targetObject" ref="jcrObservationEventListenerItems"/>

    <property name="targetMethod" value="add"/>

    <property name=“objectType” value=“java.lang.Boolean” />

    <!-- SNIP --> 

  </bean>

  TypeDeterminedMethodInvokingFactoryBean extends MethodInvokingFactoryBean, accepting predetermined objectType and so it doesn't have to even try to create the instance at all, but simply return the input objectType class to AbstractBeanFactory. AbstractBeanFactory cannot complain it any more because our custom MethodInvokingFactoryBean know what the return type is beforehand.

I think this should be simpler than adding "depends-on" in xml resources (btw, actually there are many more hidden xml resources by hst addon modules, etc. out there, so adding 'depends-on' requires a lot more maintenance efforts in my view, also there might still be some corner cases even with that change), safer and more proper because it doesn't change any bean definitions semantics.

How does it sound?

Regards,

Woonsan

 

To post to this group, send email to hippo-community@googlegroups.com

RSS: https://groups.google.com/group/hippo-community/feed/rss_v2_0_msgs.xml?num=50
---
You received this message because you are subscribed to the Google Groups "Hippo Community" group.

To unsubscribe from this group and stop receiving emails from it, send an email to hippo-community+unsubscribe@googlegroups.com.

Visit this group at https://groups.google.com/group/hippo-community.
For more options, visit https://groups.google.com/d/optout.

[Woonsan Ko]

On Wed, Mar 29, 2017 at 4:38 PM, Woonsan Ko <woons...@bloomreach.com> wrote:

On Wed, Mar 29, 2017 at 4:03 PM, 'dennis.nijssen' via Hippo Community <hippo-community@googlegroups.com> wrote:

Thank you for researching this Woonsan, although the conclusion is we can ignore the warnings, isn't it better to prevent them from happening? 

I've seen the same warning happening when adding the urlrewriter plugin. With that particular case I had the urlrewriting-context.xml in my project and was able to add depends-on="jcrObservationEventListenerItems" to the MethodInvokingFactoryBean, This made the warnings disappear. 

"depends-on" seems to make it more difficult to maintain the software.

So I have another solution:

- AbstractBeanFactory has a special routine for factory bean: #getTypeForFactoryBean(String, RootBeanDefinition).

- That routine invokes FactoryBean#getObjectType(). So in most cases, it doesn't require the factory bean to create an object only for type checking.

- However, unfortunately, MethodInvokingFactoryBean#getObjectType() was implemented to try to create an object because it is unaware of the type unlike somethings like ListFactoryBean or MapFactoryBean that can safely infer the type is either java.util.List or java.util.Map.

One minor correction: It should have been "MethodInvokingFactoryBean#getObjectType() was implemented to try to investigate the return type of the method of target object (or class) because ..."

[Woonsan Ko]

I've filed a ticket for an improvement:

- https://issues.onehippo.com/browse/HSTTWO-3953

Regards,

Woonsan

[dennis.nijssen]

Hello Woonsan,

Thank you for describing everything so clearly. I completely understand the depends-on is just a quick hack, and eventually will make the product much harder to maintain. So I believe your solution is better in terms of maintainability. 

Do you have any idea of a timeline maybe when this could be resolved? I understand it won't be released tomorrow or next week :) But can we expect it in Hippo 11.2.1 or Hippo 12 or is it even further away?

Thanks again for all the time and effort you put into researching this issue.

Kind regards,

Dennis

--

woons...@bloomreach.com     www.onehippo.com

71 Summer Street, 2nd Floor, Boston, MA 02110

Amsterdam - Oosteinde 11, 1017 WT Amsterdam
US +1 877 414 4776 (toll free)
Europe +31(0)20 522 4466

[Woonsan Ko]

On Thu, Mar 30, 2017 at 1:18 PM, 'dennis.nijssen' via Hippo Community <hippo-c...@googlegroups.com> wrote:

Hello Woonsan,

Thank you for describing everything so clearly. I completely understand the depends-on is just a quick hack, and eventually will make the product much harder to maintain. So I believe your solution is better in terms of maintainability. 

Do you have any idea of a timeline maybe when this could be resolved? I understand it won't be released tomorrow or next week :) But can we expect it in Hippo 11.2.1 or Hippo 12 or is it even further away?

Thanks again for all the time and effort you put into researching this issue.

My pleasure, it has been great to discuss this level of details with you as well!

I'll try to propose pull requests with the JIRA ticket for v12 at least. Backporting to the earlier version is up to our product management afterwards.

Regards,

Woonsan

 

To post to this group, send email to hippo-community@googlegroups.com

RSS: https://groups.google.com/group/hippo-community/feed/rss_v2_0_msgs.xml?num=50
---
You received this message because you are subscribed to the Google Groups "Hippo Community" group.

To unsubscribe from this group and stop receiving emails from it, send an email to hippo-community+unsubscribe@googlegroups.com.

Visit this group at https://groups.google.com/group/hippo-community.
For more options, visit https://groups.google.com/d/optout.