Hikari metrics

[Raman Gupta]

I noticed that HikariConfig has a method "setRecordMetrics" that is marked as "Currently not supported" and @Deprecated. However, looking at the code, the boolean does seem to cause HikariCP to hook up to a CodaHaleMetricsTracker, which is cool.

But is the "not supported" advice and @Deprecated annotation intended to reflect that that code is in incubation, or that it is marked for death? And if the latter, is there any plan to allow applications to plug in their own metrics capture mechanism?

Regards,

Raman

[Brett Wooldridge]

Metrics are planned for a future release. We are laying the groundwork now.

[Jonathan Peffer]

Does the planned support for metrics include the ability to use the Metrics project? Being able to consolidate metrics gathering within our application would be a great addition to Hikari. Designing a system that allows a metrics engine to be selected would certainly have its advantages.

[Brett Wooldridge]

Yes, the Metrics framework will be the default implementation that is used.

-Brett

[Marc Logemann]

looking forward to it. 

As this is my first post.... just want to mention that we switch with our products from C3P0 to HikariCP. Ease of use was one of our main issues with C3P0. Most of the devs were scared by the sheer volume of config settings of C3P0. And the current path to support Metrics shows a fresh view on the "old topic" database pools. 

Perhaps a nice Spring config wiki page would be nice... i could help with that... not a deal breaker if its not there, but could help attract some more people.

Marc 

[Brett Wooldridge]

Hi Marc,

There are two existing wiki pages on Spring configuration, but because there are many ways to do the same thing in Spring, any additional contributions would be welcomed.  I should also note that Spring Boot now supports HikariCP out of the box.

[Jonathan Peffer]

Fantastic news, I've really been impressed with how this entire project is evolving and being managed. Keep up the great work!