making this class final, it should not need to be overridden

0 views
Skip to first unread message

danny.a...@gmail.com

unread,
Sep 16, 2008, 11:20:01 PM9/16/08
to max....@gmail.com, hibernate-...@googlegroups.com
Reviewers: Max Ross,

Message:
This was the fix addressing the following bug
http://opensource.atlassian.com/projects/hibernate/browse/HSHARDS-51

Description:
This was the resolution that was decided in the bug

http://opensource.atlassian.com/projects/hibernate/browse/HSHARDS-51

j

Please review this at http://codereview.appspot.com/5871

Affected files:
ShardResolutionStrategyDataImpl.java


Index: ShardResolutionStrategyDataImpl.java
===================================================================
--- ShardResolutionStrategyDataImpl.java (revision 15196)
+++ ShardResolutionStrategyDataImpl.java (working copy)
@@ -23,7 +23,7 @@
/**
* @author ma...@google.com (Max Ross)
*/
-public class ShardResolutionStrategyDataImpl implements
ShardResolutionStrategyData {
+public final class ShardResolutionStrategyDataImpl implements
ShardResolutionStrategyData {
private final String entityName;
private final Serializable id;

max....@gmail.com

unread,
Sep 17, 2008, 11:48:35 AM9/17/08
to danny.a...@gmail.com, hibernate-...@googlegroups.com

max....@gmail.com

unread,
Sep 17, 2008, 11:59:39 AM9/17/08
to danny.a...@gmail.com, hibernate-...@googlegroups.com
On 2008/09/17 15:48:35, Max Ross wrote:
> LGTM

CL submitted, please mark this issue as closed.

Thanks!

Max

http://codereview.appspot.com/5871

Reply all
Reply to author
Forward
0 new messages