cannot clone https://github.com/corona-warn-app/cwa-app-ios.git

[Uwe Brauer]

Hi

I am running hg 5.2 and hggit change set 1f3155cd94f5
(because I need this named_branch feature and it is still not merged
into default).

However after some minutes I obtain



warning: can't find ancestor for 'src/xcode/ENA/ENA/Source/Services/Exposure Submission/ExposureSubmissionServiceFactory.swift' copied from 'src/xcode/ENA/ENA/Source/Services/ExposureSubmissionServiceFactory.swift'!
transaction abort!
rollback completed
abort: '\n' and '\r' disallowed in filenames: 'Icon\r'!

I pulled and run

hg up 1e55cf771b98

And repeated the clone and obtained the same problem.

So the repository is not clonable by hg-git

I have not much idea about git

Any ideas?

Uwe Brauer

[Dan Villiom Podlaski Christiansen]

Yeah, looks like a genuine bug; apparently not supporting carriage return and newline in file names is a deliberate choice in Mercurial, and the relevant bug[1] mentions an issue similar to what you're running into. Since it looks like Git doesn't have this limitation, it's something we'll need to work around.

I've been looking into auditing paths anyway, so I'll see if I can hack up something that should allow you to proceed.

The solution is twofold: 1) change the path auditing in `hggit/git_handler.py` to exclude offending paths rather than erroring out. 2) add a check for `\r` and `\n` to the auditing. I already did something similar, but towards git in the `dropdotgit` topic.

[1] https://bz.mercurial-scm.org/show_bug.cgi?id=352


--

Dan Villiom Podlaski Christiansen
dan...@gmail.com — +45 2728 9771

[Dan Villiom Podlaski Christiansen]

That wasn't too difficult, so I've created a merge request containing both:

https://foss.heptapod.net/mercurial/hg-git/-/merge_requests/72

That should allow the conversion to proceed 🙂

[Uwe Brauer]

Thanks for that quick fix. Out of curiosity I tried to run

hg clone https://foss.heptapod.net/mercurial/hg-git/-/tree/topic/default/dropdotgit

But got.
abort: HTTP Error 404: Not Found

What could be the reason?

I admit that I have no experience with pull-requests in heptapod. I have
a user id and password for raising issues.

Regards

Uwe

[Uwe Brauer]

>>> "UB" == Uwe Brauer <o...@mat.ucm.es> writes:

>> On 26 Dec 2020, at 22.56, Dan Villiom Podlaski Christiansen <dan...@gmail.com> wrote:

>> That wasn't too difficult, so I've created a merge request containing both:

>> https://foss.heptapod.net/mercurial/hg-git/-/merge_requests/72

>> That should allow the conversion to proceed 🙂

> Thanks for that quick fix. Out of curiosity I tried to run

I should have checked more carefully, sorry. Forget my email. I pulled
your change and try it out right now.

Thanks

[Uwe Brauer]

It did! However pulling and running hg in is painfully slow.

BTW, what does all these message

warning: can't find ancestor for 'src/xcode/ENA/ENA/Source/Client/HTTP Client/__tests__/WifiHTTPClientTests.swift' copied from 'src/xcode/ENA/ENA/Source/Client/HTTP Client/__tests__/WifiHTTPClient.swift'!

Mean and imply?