hg pull --confirm does not work for hg-git

[Uwe Brauer]

Hi

I am using hg 6.8 and the latest hg-git

But hg pull --confirm

Ignores the confirm option


Can anybody confirm this?

Thanks

Uwe Brauer
--
I strongly condemn Hamas heinous despicable pogroms/atrocities on Israel
I strongly condemn Putin's war of aggression against Ukraine.
I support to deliver weapons to Ukraine's military.
I support the EU and NATO membership of Ukraine.

[Dan Villiom Podlaski Christiansen]

Well, I suppose I can 😀

Most features in Mercurial, such as hooks or arguments to the push
command, have no effect with hg-git unless someone explicitly added
support for them at some point. As far as I no, no-one ever did anything
for `--confirm`, so it's probably silently ignored. TBH I've never used
it, and wasn't really aware of it until you mentioned it.

Adding support for it would probably be a bit harder than you'd think:
Pulling involves two steps with hg-git.

1) Pull from Git and add it to the local cache, i.e. Git repository.
2) Convert it to Mercurial and update the refs.

So the thing to keep in mind, for anyone poking at this, is to ensure
that subsequent pulls — even if from elsewhere, _don't_ pull the thing
you just said no to.

[Uwe Brauer]

>>> "DVPC" == Dan Villiom Podlaski Christiansen <dan...@gmail.com> writes:

> Well, I suppose I can 😀
> Most features in Mercurial, such as hooks or arguments to the push
> command, have no effect with hg-git unless someone explicitly added
> support for them at some point. As far as I no, no-one ever did
> anything for `--confirm`, so it's probably silently ignored. TBH I've
> never used it, and wasn't really aware of it until you mentioned it.

Ok, I learned it the hard way because I run once hg pull -u and then
after receiving a message I did not pay attention, I basically deleted
(instead of shelving) my uncommited changes. (Well actually it was more
complicated, I could recover the changes but the ended up in a
changeset, that would have required to run rebase (and rebase I try to
avoid at all costs)

So now I always run pull with the confirm option