PiHPSDR V2.0.0-gpiod hand mic PTT and Encoder Push switch debounce issues resolution found

[K7MDL]

FYI - I opened a few new issues in the PiHPSDR github repository recently to report and track them.   2 of them I have resolved this week.

1. Local PTT (a hand mic in my case) no working, could not compile with that option set.

2. Encoder push switch debounce code missing

Details: 

I am using a variety of normal hand and desk mics with my PiHPSDR controller V1 and V2 builds.  One is a cheap speaker mic.  

It does not seem like the PTT via GPIO logic was fully implemented yet.  I added code in gpio.c to monitor the chosen line (pin 12 in my case) and mapped the action to MOX button along with some debounce logic.  This has been working very well for me now.  Further the keyword PTT is used in the Makefile to include the PTT feature, but also used in the actions list (actions.h and actions.c) causing a compile error.  I renamed PTT top PTT_KEY in the actions lists and other places as required to resolve that.  Mapping the PTT gpio event to MOX was a clean and easy way to handle PTT, can also use the toolbar MOX button at the same time.

I am using single encoders with push switches in a Controller V1 configuration. I found there  was no debounce logic for them, only for the normal standalone switches.  The encoder structures have the same switch state fields as the normal switches but the debounce code was missing for encoder switches. I cloned the normal switch debounce code and now they work.  Changing the settle time from short to long (100 to 200ms) changes them from momentary to latching behavior.  I think there is some code work still needed but it is working well enough for now.

I am still searching the PiHPSDR code for the logic that sends specific OC filter board data to the HL2, and the best place to insert HL2 one time configuration commands at startup.   I was hoping to wedge in my Clk110MHz config commands at startup using that code as a template.   I am using a python script for now.

- Mike

[Sid Boyce]

I have 2 PiHPSDRv2 home built.

With this latest version (gpiod) I see switch problems, e.g XIT, MODE+
and BAND+ all act as MODE switches.

There were initial problems where the encoders didn't work but over the
weekend John disabled LOCALCW as suggested by Christoph.
Now the encoders are OK, the problem with switch mappings remain. That's
with the addition to /boot/config.txt
[all]
# setup GPIO for piHPSDR Controller 2
gpio=4-13,16-27=ip,pu
73 ... Sid.

> --
> You received this message because you are subscribed to the Google
> Groups "Hermes-Lite" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to hermes-lite...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/hermes-lite/4e4efe71-40ca-489b-b9bc-ff76599b2125n%40googlegroups.com
> <https://groups.google.com/d/msgid/hermes-lite/4e4efe71-40ca-489b-b9bc-ff76599b2125n%40googlegroups.com?utm_medium=email&utm_source=footer>.


--
Sid Boyce ... Hamradio License G3VBV, Licensed Private Pilot
Emeritus IBM/Amdahl Mainframes and Sun/Fujitsu Servers Tech Support
Senior Staff Specialist, Cricket Coach
Microsoft Windows Free Zone - Linux used for all Computing Tasks

[Mike Lewis]

You might check out Issue #151
https://github.com/g0orx/pihpsdr/issues/151

The encoders will not work if the pin assignments are duplicated, which they are by default in the mk2 V2 pcb template. The pin assignment conflict is hit, and the gpio monitor thread shuts down for all encoders on the error.

Easy fix, I have LOCALCW enabled, I just had to reassign the CWU and CWL gpio pins to once that did not conflict with the encoders. Since I use dual encoders with no push switches, the default switch pins 22,23,24, and 27 pins are unused. I made these CWU. CWL, Sidetone. IF you are using single encoders with switches, then use the 8 unused top encoder pins.

My solution was to modify the #defines in the top of the file gpio.c to make

Was:
int CWL_BUTTON=9;
int CWR_BUTTON=11;
int SIDETONE_GPIO=10;

Now:
int CWL_BUTTON=22;
int CWR_BUTTON=23;
int SIDETONE_GPIO=27;

recompile per the instructions in the WIKI. I made a bash script to perform those commands.

#155 and #154 may also apply to you.

- Mike

> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroup
> s.google.com%2Fd%2Fmsgid%2Fhermes-lite%2F4e4efe71-40ca-489b-b9bc-ff765
> 99b2125n%2540googlegroups.com&amp;data=04%7C01%7C%7C1ac3449758ab425d78
> 8a08d98660830d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C6376885713
> 35589576%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiL
> CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=7ZqvBazxfsueO1fAgieJIgo
> M3e02OzHVmdAQ0DjLHug%3D&amp;reserved=0
> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fd%2Fmsgid%2Fhermes-lite%2F4e4efe71-40ca-489b-b9bc-ff76599b2125n%2540googlegroups.com%3Futm_medium%3Demail%26utm_source%3Dfooter&amp;data=04%7C01%7C%7C1ac3449758ab425d788a08d98660830d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637688571335589576%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=6CzFSeAQ4aZI%2BU28efatsRjfU4CQ6JI2CFoWkriOsYc%3D&amp;reserved=0>.

--
Sid Boyce ... Hamradio License G3VBV, Licensed Private Pilot Emeritus IBM/Amdahl Mainframes and Sun/Fujitsu Servers Tech Support Senior Staff Specialist, Cricket Coach Microsoft Windows Free Zone - Linux used for all Computing Tasks

--
You received this message because you are subscribed to the Google Groups "Hermes-Lite" group.
To unsubscribe from this group and stop receiving emails from it, send an email to hermes-lite...@googlegroups.com.

To view this discussion on the web visit https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fd%2Fmsgid%2Fhermes-lite%2F509fff77-d658-0dca-f8cd-f3e771c65b28%2540gmail.com&amp;data=04%7C01%7C%7C1ac3449758ab425d788a08d98660830d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637688571335589576%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=Ht1cQaTmvxz2HIo7IR6I%2BCLKNtjFxPLPfQs%2BK0DH9tQ%3D&amp;reserved=0.

[Mike Lewis]

To your switch mapping issues, sounds like some pin are shorted, maybe solder bridging at the MCP23017.

I built a black PCB MkII V2 board and have that configured at startup. All the non-encoders switches are off the MCP23017. Chances are good if some of your switches are working and not others, you need to look at the soldering on the MCP23017, the pins are rather close together. Also test the voltage at each switch, should be about 3.2V and ground when you push them.

I use "gpio readall" command to test the switches work. Just watch the BCM pin number for each switch and see that the status flips between 1 and 0 when you push and release each switch. You may need to update the gpio library, I had to on my new RPi 4B.

You can also use the "raspi-gpio get XX" where XX is your desired pin to watch. Once you know the hardware is right through this method, then you can look at software config. The file pihpsdr/gpio.props has pin numbers defined and I manipulate those to test things out. Once I get all working good I make a backup of that file.

- Mike

-----Original Message-----
From: herme...@googlegroups.com <herme...@googlegroups.com> On Behalf Of Mike Lewis
Sent: Sunday, October 3, 2021 04:39
To: Sid Boyce <boyc...@gmail.com>; herme...@googlegroups.com
Subject: RE: PiHPSDR V2.0.0-gpiod hand mic PTT and Encoder Push switch debounce issues resolution found

You might check out Issue #151

https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fg0orx%2Fpihpsdr%2Fissues%2F151&amp;data=04%7C01%7C%7C2095a7e2629d49f5978308d986625d27%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637688579293447865%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=4cBT2QILtQT1XhlKA96ATYAMzHK9eAXh0hZWMZ7nFOg%3D&amp;reserved=0

> 99b2125n%2540googlegroups.com&data=04%7C01%7C%7C1ac3449758ab425d78
> 8a08d98660830d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C6376885713
> 35589576%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiL
> CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=7ZqvBazxfsueO1fAgieJIgo
> M3e02OzHVmdAQ0DjLHug%3D&reserved=0
> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fd%2Fmsgid%2Fhermes-lite%2F4e4efe71-40ca-489b-b9bc-ff76599b2125n%2540googlegroups.com%3Futm_medium%3Demail%26utm_source%3Dfooter&amp;data=04%7C01%7C%7C2095a7e2629d49f5978308d986625d27%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637688579293447865%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=jSNLQAAFlSrrqeMhYfpiO%2FyafDahfWxPAzbVhEaEctg%3D&amp;reserved=0>.

--
Sid Boyce ... Hamradio License G3VBV, Licensed Private Pilot Emeritus IBM/Amdahl Mainframes and Sun/Fujitsu Servers Tech Support Senior Staff Specialist, Cricket Coach Microsoft Windows Free Zone - Linux used for all Computing Tasks

--
You received this message because you are subscribed to the Google Groups "Hermes-Lite" group.
To unsubscribe from this group and stop receiving emails from it, send an email to hermes-lite...@googlegroups.com.

To view this discussion on the web visit https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fd%2Fmsgid%2Fhermes-lite%2F509fff77-d658-0dca-f8cd-f3e771c65b28%2540gmail.com&amp;data=04%7C01%7C%7C2095a7e2629d49f5978308d986625d27%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637688579293447865%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=re7cw2jnABFWUoztNt63XXby7eu8NVARRrXzg33FizM%3D&amp;reserved=0.

--
You received this message because you are subscribed to the Google Groups "Hermes-Lite" group.
To unsubscribe from this group and stop receiving emails from it, send an email to hermes-lite...@googlegroups.com.

To view this discussion on the web visit https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgroups.google.com%2Fd%2Fmsgid%2Fhermes-lite%2FCO6PR18MB3858FAE094CC16A7B0102121F6AD9%2540CO6PR18MB3858.namprd18.prod.outlook.com&amp;data=04%7C01%7C%7C2095a7e2629d49f5978308d986625d27%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637688579293447865%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=5Tujbjzc3oXB7Ooy5dnGhXVlb%2BSnDW0egnZiA9O5Nb8%3D&amp;reserved=0.