ItemCollection.exists is not working

[Andy Li]

ItemCollection.exists ( http://code.google.com/p/haxetacy/source/browse/ASP__.hx#200
) uses a function _exists defined in __init__, but since __init__ is
compiled and placed in a {} block, so actually _exists is not exist
globally, so the exists method will fail in runtime.

Here below will work:

class ItemCollectionHelper {
static public function
exists(c:ItemCollection<Dynamic>,key:String):Bool {
return c.item(key)!=c.item(' ~DUMMY`');
}
}

extern class ItemCollection<T> extends AssociativeCollection<T> {
inline function exists(key:String):Bool {
return ItemCollectionHelper.exists(this, key);
}
}

[Michiel Crefcoeur]

I've been moving some things around and haven't checked everything yet, sorry for that.

However, this is supposed to work because there is no var keyword in front of _exists so it should be a global variable. 

Will check it today.

2010/7/19 Andy Li <an...@onthewings.net>

[Michiel Crefcoeur]

I don't know what I was thinking! :-)

but it's fixed, thanks again.

2010/7/19 Michiel Crefcoeur <mpc...@gmail.com>

[Andy Li]

Thanks for the quick response! Will test it tomorrow :)

[Michiel Crefcoeur]

I suddenly realise that my project has one haxelib dependency which happens to be your jsmin lib!

:-)

2010/7/19 Andy Li <an...@onthewings.net>

[Andy Li]

haha, I know. That's great that I wrote something that useful for you and you use it in a project that useful for me. What a wonderful open source experience :)

BTW, feel free to tell me if you find anything that can be improved for jsmin.

[Michiel Crefcoeur]

In haxetacy a jsmin call is done by using com.crockford.JSMin.minify()

I do some output patching there, the comments in that class might be of interest to you.

2010/7/20 Andy Li <an...@onthewings.net>