small bugfix patch

1 view
Skip to first unread message

Malcolm Wallace

unread,
Dec 2, 2010, 9:55:55 AM12/2/10
to Haskell Chart List
Please find attached a small bugfix patch for Chart. It removes a
runtime pattern-match-failure error, in the PickFn code for
interactive hit-testing.

Regards,
Malcolm

(By the way, the patch also bumps the version number because we are
using Chart in production at work, and need a certain amount of
versioning policy to ensure reproducibility. If you'd rather I didn't
incorporate such patch-level version number bumps, I'll try to keep
them separate in future.)

patternmatch.dpatch

Tim Docker

unread,
Dec 7, 2010, 6:51:55 PM12/7/10
to haskell...@googlegroups.com
Hi,

Do we need to introduce the additional constructor L1P_Nothing? The pick
functions return
Maybe values in any case. Does the attached patch meet your needs instead?

Tim

patternmatch2.dpatch

Malcolm Wallace

unread,
Jan 7, 2011, 8:35:11 AM1/7/11
to haskell...@googlegroups.com
> Do we need to introduce the additional constructor L1P_Nothing? The
> pick functions return Maybe values in any case. Does the attached
> patch meet your needs instead?

Sorry for the delay in response - sure, your version of this patch
looks better than mine. (But I could not apply it directly, because
it depends on at least one other unpublished patch of yours.)

Regards,
Malcolm

Tim Docker

unread,
Jan 11, 2011, 11:11:32 PM1/11/11
to haskell...@googlegroups.com

> Sorry for the delay in response - sure, your version of this patch
> looks better than mine. (But I could not apply it directly, because
> it depends on at least one other unpublished patch of yours.)

I've pushed this.

Tim

Reply all
Reply to author
Forward
0 new messages