run-tri.sh change

22 views
Skip to first unread message

Russell Teague

unread,
Jun 11, 2014, 8:16:45 AM6/11/14
to hanlon-...@googlegroups.com

This script points to a specific IP address.  Based on the recommendation from Joe and git best practices, this should be changed to 0.0.0.0 so it is functional regardless of the environment.  Since this is trivial I didn't submit an issue but I'll be happy to do so if that is the right way to go about it.

CURRENT
reset
trinidad -c /hanlon/api -d ../web  --address 192.168.109.5 -p 8026 2>&1 | tee trinidad.log

SUGGESTED
reset
trinidad -c /hanlon/api -d ../web  --address 0.0.0.0 -p 8026 2>&1 | tee trinidad.log

Alexander Popov

unread,
Jun 11, 2014, 8:33:53 AM6/11/14
to hanlon-...@googlegroups.com
Thanks Russell,

Please create an issue - when you submit a pull request (PR) people will want to understand why you are making changes and will let others who come across the same problem know that developers are aware of it.

Regards,

Alex

Sankar Vema

unread,
Jun 12, 2014, 12:50:06 AM6/12/14
to hanlon-...@googlegroups.com
This issue fixed as part of the new pull request https://github.com/csc/Hanlon/pull/57
Reply all
Reply to author
Forward
0 new messages