Anyone reading bug reports?

27 views
Skip to first unread message

Doug Mayer

unread,
Feb 9, 2012, 3:53:32 PM2/9/12
to Haml
What's a guy got to do to get a bug report looked at?

https://github.com/nex3/haml/pull/419

Nathan Weizenbaum

unread,
Feb 13, 2012, 3:46:38 PM2/13/12
to ha...@googlegroups.com
I read them, but Sass is currently much higher piority for the limited amount of time I have to spend on OSS.

On Thu, Feb 9, 2012 at 12:53 PM, Doug Mayer <do...@ebackpack.com> wrote:
What's a guy got to do to get a bug report looked at?

https://github.com/nex3/haml/pull/419

--
You received this message because you are subscribed to the Google Groups "Haml" group.
To post to this group, send email to ha...@googlegroups.com.
To unsubscribe from this group, send email to haml+uns...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/haml?hl=en.


Stephen Bannasch

unread,
Feb 13, 2012, 10:22:46 PM2/13/12
to ha...@googlegroups.com
At 12:46 PM -0800 2/13/12, Nathan Weizenbaum wrote:
I read them, but Sass is currently much higher piority for the limited amount of time I have to spend on OSS.

Is there anybody else who you trust enough to delegate review of pull requests to?

I created tests for both of these pull requests when I made them.

If there is ANYTHING I can do to improve them to get them accepted I'd love to get the feedback,

At 5:13 PM -0400 9/18/11, Stephen Bannasch wrote:
Do you guys have time to review pull requests?

If not are you looking for another maintainer who can help?

Since April five pull requests have been closed but there are 12 outstanding pull requests since April with no comments from either of you.

I'm now using a fork with these two pull requests merged:
  Escape with key codes instead of named HTML entities (for IE support) #418
  July 22, 2011
  https://github.com/nex3/haml/pull/419

  ActionView::Template mime type of 'text/xml' forces :xhtml
  September 09, 2011
  https://github.com/nex3/haml/pull/427

Both of these have tests.

Doug Mayer

unread,
Feb 13, 2012, 10:50:25 PM2/13/12
to ha...@googlegroups.com

To be fair, I actually need to modify the tests for #419, since it is actually testing for the IE-invalid output today. :)

But we have been using it in production since before I originally posted it, and have to support just about every old-busted and new-hotness browser out there. (Yay educational software.) If you're using something like Dojo where you need to encode JSON data in a data- attribute, while not killing IE, you need to run a patched version of Haml.

On Feb 13, 2012 9:22 PM, "Stephen Bannasch" <stephen....@deanbrook.org> wrote:
At 12:46 PM -0800 2/13/12, Nathan Weizenbaum wrote:
I read them, but Sass is currently much higher piority for the limited amount of time I have to spend on OSS.

Is there anybody else who you trust enough to delegate review of pull requests to?

I created tests for both of these pull requests when I made them.

If there is ANYTHING I can do to improve them to get them accepted I'd love to get the feedback,

At 5:13 PM -0400 9/18/11, Stephen Bannasch wrote:
Do you guys have time to review pull requests?

If not are you looking for another maintainer who can help?

Since April five pull requests have been closed but there are 12 outstanding pull requests since April with no comments from either of you.

I'm now using a fork with these two pull requests merged:
  Escape with key codes instead of named HTML entities (for IE support) #418
  July 22, 2011
  https://github.com/nex3/haml/pull/419

  ActionView::Template mime type of 'text/xml' forces :xhtml
  September 09, 2011
  https://github.com/nex3/haml/pull/427

Both of these have tests.

















On Thu, Feb 9, 2012 at 12:53 PM, Doug Mayer <do...@ebackpack.com> wrote:
What's a guy got to do to get a bug report looked at?
https://github.com/nex3/haml/pull/419

--
You received this message because you are subscribed to the Google Groups "Haml" group.
To post to this group, send email to
ha...@googlegroups.com.
To unsubscribe from this group, send email to
haml+uns...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/haml?hl=en.

--
You received this message because you are subscribed to the Google Groups "Haml" group.
To post to this group, send email to ha...@googlegroups.com.
To unsubscribe from this group, send email to haml+uns...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/haml?hl=en.

Reply all
Reply to author
Forward
0 new messages