Pagination broken in HEAD

2 views
Skip to first unread message

Raman Ng (tinyau)

unread,
Dec 4, 2007, 4:22:02 AM12/4/07
to habar...@googlegroups.com
After the changes of 'display_entry' and 'display_page' rewrite rules in r1173, the pagination broken.

-                       array( 'name' => 'display_entry', 'parse_regex'
=> '%^(?P<slug>[^/]+)(?:/page/(?P
<page>\d+))?/?$%i', 'build_str'
=> '{$slug}(/page/{$page})', 'handler' => 'UserThemeHandler', 'action'
=> 'display_post', 'priority' => 100, 'description' => 'Return entry
matching specified slug' ),
-                       array( 'name' => 'display_page', 'parse_regex'
=> '%^(?P<slug>[^/]+)(?:/page/(?P<page>\d+))?/?$%i', 'build_str'
=> '{$slug}(/page/{$page})', 'handler' => 'UserThemeHandler', 'action'
=> 'display_post', 'priority' => 100, 'description' => 'Return page
matching specified slug' ),
+                       array( 'name' => 'display_entry', 'parse_regex'
=> '%^(?P<slug>.+)(?:/page/(?P<page>\d+))?/?$%i', 'build_str'
=> '{$slug}(/page/{$page})', 'handler' => 'UserThemeHandler', 'action'
=> 'display_post', 'priority' => 100, 'description' => 'Return entry
matching specified slug' ),
+                       array( 'name' => 'display_page', 'parse_regex'
=> '%^(?P<slug>.+)(?:/page/(?P<page>\d+))?/?$%i', 'build_str'
=> '{$slug}(/page/{$page})', 'handler' => 'UserThemeHandler', 'action'
=> 'display_post', 'priority' => 100, 'description' => 'Return page
matching specified slug' ),

As I'm not good at regular expression, I don't know what the purpose of this changes. 

I don't know if the proper fix of this problem is to change priority of 'display_home' to 99, i.e. higher than 'display_entry' and 'display_page'.

Any advise?

--
Cheers,
Raman (tinyau)
Blog: http://blog.tinyau.net

Andrew da Silva

unread,
Dec 4, 2007, 8:45:18 PM12/4/07
to habari-dev
Would it possible to post this in the issue tracker as well as include
the output?

The modifications I made were to reflect other rewrite rules, and they
shouldn't break anything unless you are using forward slashes in a
slug, which is not supported thus the exclusion.

With an output and how you call the pagination, we can debug easily :)

On Dec 4, 4:22 am, "Raman Ng (tinyau)" <tinyau.vamp...@gmail.com>
wrote:

Raman Ng (tinyau)

unread,
Dec 4, 2007, 11:03:36 PM12/4/07
to habar...@googlegroups.com
Fixed in r1179, thanks ringmaster.
Reply all
Reply to author
Forward
0 new messages