Patch for gyp issue 302

[TJ Grant]

Fixes issue reported here: http://code.google.com/p/gyp/issues/detail?id=302&can=4

Prior to this patch, Xcode 4.5.x will throw a warning for every project and "action"(subproject), stating that each project and subproject needs to be "upgraded" because the flag "COMBINE_HIDPI_IMAGES" isn't set.

(And forces you to set the flag (with default of "YES") to get rid of the warning.)

This patch then just turns the flag on by default, and gets rid of the warnings altogether.

---

 pylib/gyp/xcodeproj_file.py |    1 +

 1 file changed, 1 insertion(+)

diff --git a/pylib/gyp/xcodeproj_file.py b/pylib/gyp/xcodeproj_file.py

index ec4cb96..2c3813b 100644

--- a/pylib/gyp/xcodeproj_file.py

+++ b/pylib/gyp/xcodeproj_file.py

@@ -2145,6 +2145,7 @@ class XCTarget(XCRemoteObject):

         if configs.HasBuildSetting('PRODUCT_NAME') == 0:

           configs.SetBuildSetting('PRODUCT_NAME',

                                   self._properties['productName'])

+          configs.SetBuildSetting('COMBINE_HIDPI_IMAGES', 'YES')

 

   def AddDependency(self, other):

     pbxproject = self.PBXProjectAncestor()

-- 

1.7.10.2 (Apple Git-33)

--TJ Grant
tjg...@tatewake.com

[TJ Grant]

Thakis et al…

Is there a procedure to submit patches from non-team members?

Thanks in advance,
--TJ Grant
tjg...@tatewake.com

[Ryan Sleevi]

Hi TJ,

An old mail from https://groups.google.com/group/gyp-developer/msg/7284216f8a507d8a should document the necessary steps

1) Fill out a Contributor License Agreement

2) Use depot_tools to upload the CL to codereview.chromium.org

3) Make sure gyp-developer is copied in the CC list, and ask someone to review it.

  - Don't forget to Publish Comments to actually send them the e-mail

4) Profit! (or at least, get valuable feedback)

--
 
 
 

[TJ Grant]

Thanks!