Additions
sander
Would you be interested in sharing your additions/improvements to
GWTLib?
Thanks,
Sander
Alan Hadsell
On Feb 22, 2:54 pm, sander <sanderbere...@gmail.com> wrote:
> Would you be interested in sharing your additions/improvements to
> GWTLib?
Absolutely. That's why I'm here.
Changes so far: I brought the library up-to-speed with version 2.0.2.
Most of the
changes are Listener->Handler stuff, but I also changed the "int type"
in the MenuItem
to an enum. I have tested the Menu changes with Chrome, Firefox and
IE8, none of
the other changes have been tested yet.
Let me know how to get the changes to you.
Alan Hadsell
On Feb 23, 2:23 pm, Alan Hadsell <ahads...@gmail.com> wrote:
> I have tested the Menu changes with Chrome, Firefox and
> IE8
For some reason, IE is now failing with a null pointer
exception. Working on it.
Alan Hadsell
> For some reason, IE is now failing with a null pointer
> exception. Working on it.
Yes, I'm replying to myself _again_.
This is the problem:
http://code.google.com/p/google-web-toolkit/issues/detail?id=4584
Adding a GWT history iframe to your html page is a valid workaround.
Supposed to be fixed in gwt-2.0.3.
Sander Berents
> --
> You received this message because you are subscribed to the Google Groups "GWTLib" group.
> To post to this group, send email to gwt...@googlegroups.com.
> To unsubscribe from this group, send email to gwtlib+un...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/gwtlib?hl=en.
>
Alan Hadsell
On Feb 24, 1:12 pm, Sander Berents <sanderbere...@gmail.com> wrote:
> Sounds good Alan. You could create a new "Issue" and attach the patches to it. We would apply them to trunk. I could do that initially or just enable commit permissions for you (I have added you as contributor already).
Thanks. I'll go the "issue" route for now. I'd rather have you vet
the patches, since I made some design decisions that you might
disagree with. I need to break the patches up into digestable
chunks. I'll start doing that and submitting them this afternoon (US
Eastern time)
Alan Hadsell
On Feb 24, 1:12 pm, Sander Berents <sanderbere...@gmail.com> wrote:
> Sounds good Alan. You could create a new "Issue" and attach the patches to it. We would apply them to trunk. I could do that initially or just enable commit permissions for you (I have added you as contributor already).
>
One question: My current changes _remove_ the support for the old
Listener mechanism, which of course will break any existing
applications using GWTLib. Would you prefer that I maintain and
deprecate the old mechanism? Doing so will add quite a bit of code
and take some time, but I can do so if you need it.
Sander Berents
Alan Hadsell
On Feb 25, 7:01 pm, Sander Berents <sanderbere...@gmail.com> wrote:
> I don't mind removing the old code in this case.
Thanks, that makes my job easier. I don't have any use for the older
code, but I thought you might.
I have attached the patches to issue 4 <http://code.google.com/p/
gwtlib/issues/detail?id=4>. Please take a look and let me know what
changes you'd like.
Cheers,
Alan Hadsell
Alan Hadsell
On Feb 27, 1:55 pm, Alan Hadsell <ahads...@gmail.com> wrote:
> I have attached the patches to issue 4 <http://code.google.com/p/
> gwtlib/issues/detail?id=4>. Please take a look and let me know what
> changes you'd like.
Anyone? Bueller?
Sander Berents
I've been too busy this past week to look into it, but will apply the patches soon.
Ferris
sander
I finally applied the patches, made a few more minor changes, tested
them, and released it all as 1.0.0. I could have released it as 0.1.7,
but as I am using the library in a production environment since
release 0.1.0, I figured it is long overdue for the 1.x tag.
Thanks for the patches!
Sander