RC2 issues - ModalDialog#add

[doubtintom]

Matt, I needed to upgrade to 1.4 RC2 to pick up some of the fixes
therein. As I encounter issues that RC2 creates with GWT Tk, would you
prefer I document them here on the list, or in the issue tracker?

I hope my experiences will save some time for you and others.

When adding a single widget to a ModalDialog, this piece of code in
ExposedCellPanel#insertWidgetAt required a small change. Google had
depreciated the protected void insert(Widget child, Element container,
int beforeIndex) method. That method now throws an error if null is
passed as the container param.

The new method is protected void insert(Widget child,
Element container,
int beforeIndex,
boolean domInsert)
which also wants a non-null container, and will take care of the
DOM.insert. So below is the code change that is working for me. Note
that the creation of the td now comes before the insert call.

approx. line #339 - NEW
/*
* Pass null and append the element manually so that we can specify
* insertion order. Also note that the order of the "children"
* WidgetCollection is not maintained.
*/
// insert(w, null, getChildren().size());
Element td = getCellElement(cellIndex);
insert(w, td, getChildren().size(), true);
// DOM.insertChild(td, w.getElement(), wIndex);
}

approx. line #339 - OLD
/*
* Pass null and append the element manually so that we can specify
* insertion order. Also note that the order of the "children"
* WidgetCollection is not maintained.
*/
insert(w, null, getChildren().size());
Element td = getCellElement(cellIndex);
DOM.insertChild(td, w.getElement(), wIndex);
}

Tom

[Mat Gessel]

Hi Tom,

Thanks for the report. The best approach for tracking issues is to
write up the issue in the tracker, then reference it from the forum.
The tracker will ensure I don't miss it, and the forum will help
others find the issue.

--
Mat Gessel
http://www.asquare.net/gwttk/

[zierfis...@googlemail.com]

I just added it to the tracker
http://code.google.com/p/gwt-tk/issues/detail?id=17

On 23 Aug., 20:25, "Mat Gessel" <mat.ges...@gmail.com> wrote:
> Hi Tom,
>
> Thanks for the report. The best approach for tracking issues is to
> write up the issue in the tracker, then reference it from the forum.
> The tracker will ensure I don't miss it, and the forum will help
> others find the issue.
>
> --
> Mat Gesselhttp://www.asquare.net/gwttk/
>