Request to merge projects

[halfof...@gmail.com]

I have a number of changes (I've already emailed one of you about it) and I'd like to merge with your project instead of creating another fork.

The most significant change is multiline text boxes (which are not 100% complete, it's more like 50%), but there are a large number of usability upgrades, like being able to disable Combo boxes and removing all children from a few controls (like ListBoxes, iirc).

Anyways, here is the patch file, if you want to wait for me to hammer out the bugs that Multiline text boxes introduced, as well as wait for it to actually work more than what it is, I understand.

[Robin]

Commit them in smaller chunks if possible.

If you are sure that the multilinebox changes don't break any of the existing unittests it should be fine.

I see you've reverted some changes. I'm not sure if you did it on purpose.

eg:

--- Gwen/Control/ColorSlider.cs (revision 120)
+++ Gwen/Control/ColorSlider.cs (working copy)
@@ -70,7 +70,6 @@
m_Texture.LoadRaw(Width, Height, pixelData);
}
- skin.Renderer.DrawColor = Color.White;
skin.Renderer.DrawTexturedRect(m_Texture, new Rectangle(5, 0, Width-10, Height));

Would be cool if you added some unittest for your new features so we can try them out :-D

[Nicholas Rodine]

I could have sworn I excluded that one. I'll go over it again with a comb in the morning, and throw together some unit tests.

One of the most inconvenient issues is having to set the auto resize flag for every label, and the crazy '.Menu' bit when dealing with menu straps. I left those changes out, for various reasons.

--
You received this message because you are subscribed to a topic in the Google Groups "gwen-dotnet" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/gwen-dotnet/XXwN0Ztbox0/unsubscribe?hl=en.
To unsubscribe from this group and all its topics, send an email to gwen-dotnet...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

[halfof...@gmail.com]

Here is the latest version of my diffs:

It is too difficult for me to split them up into multiple diffs, simply because a number of changes overlap and it's hard to document which changes are for which lines without going through my revision history.

I've started including unit tests for some of my changes. In particular check out:

• Text Box (multiline)
• Combobox (changing selected item in code. In the test, through a button.)

I'd recommend delaying the merge until I write up one huge changelist (for the commit log) and some more unit tests for the rest of my changes.