Re: LoadFont and Menu
20 views
Skip to first unread message
Isaac Wagner
Jul 21, 2011, 7:16:32 PM7/21/11
to gwen-d...@googlegroups.com
On Thu, Jul 14, 2011 at 2:19 PM, Garry Newman <garry...@gmail.com> wrote:
I think that it should either be called automatically by something in Gwen, or it should be removed as a virtual function. A virtual function that isn't actually called by anything externally is going to be very confusing.
And one code suggestion: an Open() function in the Menu class. I know that you can just set hidden to false, but if you have a Close(), an Open() would be a logical function to have as well. I am using a Menu as a right-click context menu and it works quite well. Was that the intention, or is it meant to be part of a menu at the top of the screen (e.g. File, Edit, View, ...)?
With LoadFont - I can see the confusion. I wonder whether it would be better to have a function on the base renderer which automatically calls LoadFont and then MeasureText/RenderText. Then MeasureText/RenderText would be made protected? That would probably kill that confusion?garry
I think that it should either be called automatically by something in Gwen, or it should be removed as a virtual function. A virtual function that isn't actually called by anything externally is going to be very confusing.
And one code suggestion: an Open() function in the Menu class. I know that you can just set hidden to false, but if you have a Close(), an Open() would be a logical function to have as well. I am using a Menu as a right-click context menu and it works quite well. Was that the intention, or is it meant to be part of a menu at the top of the screen (e.g. File, Edit, View, ...)?
Reply all
Reply to author
Forward
0 new messages