Should gwd-inactive set "display: none" instead of "visibility: hidden"?

231 views
Skip to first unread message

micsun-al

unread,
Dec 11, 2015, 9:28:18 PM12/11/15
to Google Web Designer beta
Should the gwd-inactive class maybe set "display: none" instead of "visibility: hidden"?

In an expanding ad, if some element has "transition: all 1s ease" set in the css, then "visibility: hidden" will not apply until after the 1s duration passes.  When collapsing the expand, the images will hang out until the transition duration completes and it looks weird.

A workaround to this is the following:

.gwd-inactive {
 display
: none;
}

Is this the wrong way to fix this problem?

Should this possibly be the default for gwd-inactive or do the page transitions or something along those lines require it?

bortignon

unread,
Dec 11, 2015, 9:32:28 PM12/11/15
to Google Web Designer beta
Unfortunately, the Display: none; interact with few with our component (maps and youtube video). 
Given the nature of this components (black box based on Maps and Youtube API) there is no much that can be done to stop the interaction. Hence the use of visibility: hidden.

Your fix is indeed correct, as long as the aforementioned  components are not involved. 
Reply all
Reply to author
Forward
0 new messages