can 'gvn approve' send emails?

1 view
Skip to first unread message

Jesse

unread,
Mar 31, 2009, 6:18:29 PM3/31/09
to gvn-discuss
Currently, when my code reviewer approves my change, I don't get any
sort of notification of this except if he writes me an email by hand.
Can 'gvn approve' automatically send an email to notify the requester
that the change has been approved?

e...@google.com

unread,
Apr 1, 2009, 12:10:13 PM4/1/09
to Jesse, gvn-discuss
Jesse <jesse...@gmail.com> writes:

gvn approve doesn't do that, no. We thought the right approach
was for the post-revprop-change hook to send that message.
I don't think we ever implemented that, though.

Jesse Shieh

unread,
Apr 1, 2009, 2:03:59 PM4/1/09
to e...@google.com, gvn-discuss
Do you mind if I take a stab at the implementation?

--
Sent from my mobile device

Jesse Shieh (謝肇希)
US: +(1) 415.615.2598
China: +(86) 135.8160.6052

e...@google.com

unread,
Apr 1, 2009, 3:54:12 PM4/1/09
to Jesse Shieh, gvn-discuss
Jesse Shieh <jesse...@gmail.com> writes:

> Do you mind if I take a stab at the implementation?

Well, we don't work on gvn anymore. We may or may not find time
to review the patch, but feel free to post it. Maybe others will
benefit. I don't think there's any longer anyone else to benefit,
though.

Jesse Shieh

unread,
Apr 1, 2009, 5:06:06 PM4/1/09
to e...@google.com, Jesse Shieh, gvn-discuss
I'm really surprised that nobody uses or works on gvn anymore.  It seemed like the only viable code review wrapper for svn that I could find. 
--
Reply all
Reply to author
Forward
0 new messages