Issue 55 in peaberry: Integration between the Activation bundle and the GuiceExtensionFactory

11 views
Skip to first unread message

peab...@googlecode.com

unread,
Mar 4, 2011, 2:58:54 PM3/4/11
to guice...@googlegroups.com
Status: New
Owner: ----
Labels: Type-Enhancement Priority-Medium

New issue 55 by matthias...@gmx.de: Integration between the Activation
bundle and the GuiceExtensionFactory
http://code.google.com/p/peaberry/issues/detail?id=55

The Activation bundle and the GuiceExtensionFactory seem to make a
perfect pair for developing Eclipse RCP applications. You don't have
to write any bootstrap code and may use osgi Declarative Services (DS)
without any additional efforts.

After I played around with this scenario for a few hours, I noticed
that the GuiceExtensionFactory creates a new Injector for each module,
even if an
Injector has already been created for that bundle. I don't think that
this makes any sense because the scope of a singletons belongs to it's
Injector (Singletons are created multiple times, one for each Injector).

I noticed that the Spring guys found a nice solution to this by using
an ServiceTracker to retrieve the existing applicationContext from the
osgi environment. If there is any Interest, I could provide a patch
for this. (*http://tinyurl.com/5sgzhxw)*

Are there any upcoming releases? Or has the development been stopped
because auf E4's DI support?

peab...@googlecode.com

unread,
Mar 7, 2011, 3:51:12 AM3/7/11
to guice...@googlegroups.com

Comment #1 on issue 55 by Rinsvind: Integration between the Activation
bundle and the GuiceExtensionFactory
http://code.google.com/p/peaberry/issues/detail?id=55

I don't quite understand why do you need to use OSGi DS together with
Peaberry. Just Peaberry is sufficient to handle dynamic services and IMO in
a better way than OSGi DS.

peab...@googlecode.com

unread,
Mar 7, 2011, 6:19:54 AM3/7/11
to guice...@googlegroups.com

Comment #2 on issue 55 by matthias...@gmx.de: Integration between the
Activation bundle and the GuiceExtensionFactory
http://code.google.com/p/peaberry/issues/detail?id=55

Sorry for not being clear enough on this. I use Peaberry for exporting OSGi
DS.

This problem ist just, that the GuiceExtensionFactory is creating it's own
Injector, even if an Injector has already been created for the bundle.

peab...@googlecode.com

unread,
Mar 7, 2011, 9:56:40 AM3/7/11
to guice...@googlegroups.com

Comment #3 on issue 55 by mccu...@gmail.com: Integration between the
Activation bundle and the GuiceExtensionFactory
http://code.google.com/p/peaberry/issues/detail?id=55

I've been gradually moving peaberry's OSGi functionality over to our new
JSR330 based container "sisu-inject" which is already used in Maven3 and
Nexus (https://github.com/sonatype/sisu). Sisu (when run in OSGi mode) uses
a service listener to track bundle injectors to avoid duplicates. The
equivalent GuiceExtensionFactory is not fully functional yet (full OSGi
support is scheduled for the upcoming 2.3.0 release) but the basics are in
place.

So while my focus at the moment (and the foreseeable future) is
on "sisu-inject", if you want to patch peaberry to fix this particular
problem then I'm happy to merge it in and roll out a new release.

peab...@googlecode.com

unread,
Aug 4, 2012, 5:43:31 PM8/4/12
to guice...@googlegroups.com
Updates:
Labels: Peaberry-Extension

Comment #4 on issue 55 by mccu...@gmail.com: Integration between the
Activation bundle and the GuiceExtensionFactory
http://code.google.com/p/peaberry/issues/detail?id=55

(No comment was entered for this change.)

peab...@googlecode.com

unread,
Jun 21, 2015, 9:44:43 PM6/21/15
to guice...@googlegroups.com
Updates:
Status: Duplicate

Comment #5 on issue 55 by mccu...@gmail.com: Integration between the
Activation bundle and the GuiceExtensionFactory
https://code.google.com/p/peaberry/issues/detail?id=55

Moved to https://github.com/ops4j/peaberry/issues/58

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
Reply all
Reply to author
Forward
0 new messages