Languishing PR to grpc/grpc: what to do to make it more mergable?

[Christopher Warrington - MSFT]

I created a PR with a build fix for the CMake build on May 7, #18984 "Fix
CMake upb build: add missing headers directory" [1]. It's been needing a
review from someone on the gRPC team since then. I've pinged the PR three
times since then. Is there something else I should be doing to get this
merged?

I have other changes in this space that are stuck behind this PR, as I need
to get the tests building properly before I can submit my subsequent PRs.
I'm trying to get gRPC building with CMake 3.5. The minimum supported
version is currently 2.8, but anything older than 3.5 is currently broken
[2].

[1]: https://github.com/grpc/grpc/pull/18984
[2]: https://github.com/grpc/grpc/issues/18559

--
Christopher Warrington
Microsoft Corp.

[Jan Tattermusch]

Hey Christopher,

sorry for the delay. Looked at your upb inclusion fix and ended up creating a new PR as more changes were needed: https://github.com/grpc/grpc/pull/19384

That should unblock your work to fix https://github.com/grpc/grpc/issues/18559

--
You received this message because you are subscribed to the Google Groups "grpc.io" group.
To unsubscribe from this group and stop receiving emails from it, send an email to grpc-io+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/grpc-io/91dd958e-95e4-4615-b0ae-c90872b498ab%40googlegroups.com.

--

Jan