Possible for memory leak

[mauricio...@lacity.org]

I'm running this on Centos 7 c++.  

The async example https://chromium.googlesource.com/external/github.com/grpc/grpc/+/chromium-deps/2016-07-19/examples/cpp/helloworld/greeter_async_client2.cc shows how you handle responses from the server.  The example uses new to create a structure to hold rpc data and it isn't deleted until the response is received from the server.  If the server is not able to acknowledge the message, memory allocated will never be freed.  Is there something I'm missing?

[Nicolas Noble]

You're basically making the case for why deadlines are mandatory. https://grpc.io/blog/deadlines/ - 
The example you're linking is very simplistic, and doesn't follow this deadline rule, but is aimed at showing a very simple boilerplate on how to issue an RPC, which is always a difficult balance between how cluttered the simplest example code should be versus how much streamlined it should be.

Using deadlines, you're guaranteed to get an event in which you will free memory.

On Fri, Nov 15, 2019 at 2:31 PM <mauricio...@lacity.org> wrote:

I'm running this on Centos 7 c++.  

The async example https://chromium.googlesource.com/external/github.com/grpc/grpc/+/chromium-deps/2016-07-19/examples/cpp/helloworld/greeter_async_client2.cc shows how you handle responses from the server.  The example uses new to create a structure to hold rpc data and it isn't deleted until the response is received from the server.  If the server is not able to acknowledge the message, memory allocated will never be freed.  Is there something I'm missing?

--
You received this message because you are subscribed to the Google Groups "grpc.io" group.
To unsubscribe from this group and stop receiving emails from it, send an email to grpc-io+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/grpc-io/6d7ac733-8199-4ae3-b642-27146cb4307b%40googlegroups.com.

[mauricio...@lacity.org]

I knew I had to be missing something.  Thank you!

On Friday, November 15, 2019 at 3:25:40 PM UTC-8, Nicolas Noble wrote:

You're basically making the case for why deadlines are mandatory. https://grpc.io/blog/deadlines/ - 
The example you're linking is very simplistic, and doesn't follow this deadline rule, but is aimed at showing a very simple boilerplate on how to issue an RPC, which is always a difficult balance between how cluttered the simplest example code should be versus how much streamlined it should be.

Using deadlines, you're guaranteed to get an event in which you will free memory.

On Fri, Nov 15, 2019 at 2:31 PM <maurici...@lacity.org> wrote:

I'm running this on Centos 7 c++.  

The async example https://chromium.googlesource.com/external/github.com/grpc/grpc/+/chromium-deps/2016-07-19/examples/cpp/helloworld/greeter_async_client2.cc shows how you handle responses from the server.  The example uses new to create a structure to hold rpc data and it isn't deleted until the response is received from the server.  If the server is not able to acknowledge the message, memory allocated will never be freed.  Is there something I'm missing?

--
You received this message because you are subscribed to the Google Groups "grpc.io" group.

To unsubscribe from this group and stop receiving emails from it, send an email to grp...@googlegroups.com.