L52 gRFC: Require static strings for method and host passed to grpc_channel_register_call()

[Soheil Hassas Yeganeh]

This is the discussion thread for L52 gRFC: Require static strings for method and host passed to grpc_channel_register_call() 

Please let me know if you have any concerns.

[Christopher Warrington - MSFT]

On Tuesday, June 11, 2019 at 12:06:44 PM UTC-7, Soheil Hassas Yeganeh wrote:

> This is the discussion thread for L52 gRFC: Require static strings for
> method and host passed to grpc_channel_register_call()

Consider adding a definition of what is meant by "static string". My first
reaction was "Why does the linkage of the string matter? What's wrong with
an extern const char* SOME_METHOD="frob";" This is about lifetime--not
linkage, as you mentioned in the Rational section. That looks like a good
starting point for defining a static string.

--
Christopher Warrington
Microsoft Corp.

[Soheil Hassas Yeganeh]

Thank you for the quick review, Christopher. I understand your point,
but I couldn't find a single word to explain it. I chose
"static_string" since that's what used by the slice API, to refer to
strings that are kept valid by the caller.

I added a brief explanation in the abstract, hoping that it would
address your concern.

Thanks,
Soheil

> --
> Christopher Warrington
> Microsoft Corp.
>

> --
> You received this message because you are subscribed to the Google Groups "grpc.io" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to grpc-io+u...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/grpc-io/23f11c81-6b5f-4bc0-aa07-80d2ee219947%40googlegroups.com.

[Christopher Warrington - MSFT]

On Tuesday, June 11, 2019 at 3:29:03 PM UTC-7, Soheil Hassas Yeganeh wrote:

> I added a brief explanation in the abstract, hoping that it would
address your concern.

Your update looks good to me.

[Soheil Hassas Yeganeh]

On Tue, Jun 11, 2019 at 7:50 PM 'Christopher Warrington - MSFT' via
grpc.io <grp...@googlegroups.com> wrote:
>
> On Tuesday, June 11, 2019 at 3:29:03 PM UTC-7, Soheil Hassas Yeganeh wrote:
>
> > I added a brief explanation in the abstract, hoping that it would
> address your concern.
>
> Your update looks good to me.

Thank you for the review.

> --
> Christopher Warrington
> Microsoft Corp.
>

> --
> You received this message because you are subscribed to the Google Groups "grpc.io" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to grpc-io+u...@googlegroups.com.

> To view this discussion on the web visit https://groups.google.com/d/msgid/grpc-io/d478bd03-3e6b-4078-af8b-fe92bd7b5f59%40googlegroups.com.