gRFC L25: Make GrpcBuffer{Reader|Writer} Public

51 views
Skip to first unread message

ncte...@google.com

unread,
Feb 28, 2018, 2:38:06 PM2/28/18
to grpc.io
Created a new gRFC, feel free to drop comments here or on the PR itself.

gRFC: https://github.com/grpc/proposal/pull/61

Christopher Warrington - MSFT

unread,
Feb 28, 2018, 9:33:40 PM2/28/18
to grpc.io
Looking at the implementation, this inherits from ::grpc::protobuf::io::ZeroCopyOutputStream, which implies a dependency on protobuf.

Is that the case?
    * If so, should this be called, say, GrpcProtoBufferReader instead?
    * If this isn't used by the client of gRPC, can building and linking with proto be omitted?

As someone who uses gRPC with a different serialization library, I'd like to be able to not have to build or link with protobuf unless I'm using things explicitly implemented in terms of proto messages, like channel tracing.

--
Christopher Warrington
Microsoft Corp.

ncte...@google.com

unread,
Mar 1, 2018, 5:34:13 PM3/1/18
to grpc.io
Yes, this class would only be used with protobuf. I like your suggested rename to GrpcProtoBufferReader, and I will incorporate that change before merging.

As of now, the the newly public classes are only being used by our codegen, which is already proto dependent. We will ensure that any code not using the generated code does not pick proto dependency.

ncte...@google.com

unread,
Jul 2, 2018, 1:54:51 PM7/2/18
to grpc.io
Part 2 of this project is underway:


Feel free to comment here or on the PR.
Reply all
Reply to author
Forward
0 new messages