Growl fork for build on latest XCode and graphic card plugin for HardwareGrowler

[Jérôme Chauvin]

Hello,

I made a fork of latest Growl sources to add some new features :

• Build on XCode 6
• Update to 10.8 target
• Use ARC
• Add GraphicCardMonitor plugin (using code from gfxCardStatus)

The fork is hosted on github https://github.com/tazounet/growl

Jérôme

[John Hawkinson]

[ moved from growl-discuss ]

John Hawkinson <jh...@mit.edu> wrote on Thu, 13 Aug 2015
at 16:05:13 -0400 in <rodoaib...@contents-vnder-pressvre.mit.edu>:

> I recently moved from a Mavericks machine to a Yosemite machine, and
> now it's not possible to expand truncated growl messages in the rollup
> window.
...
> But under Yosemite, double-clicking the item in the rollup does not
> expand it (nothing happens). All settings seem to be the same.

I don't really understand what's going on, but this patch:

--- a/Core/Source/GrowlNotificationHistoryWindow.m
+++ b/Core/Source/GrowlNotificationHistoryWindow.m
@@ -26,7 +26,8 @@

#define GROWL_DESCRIPTION_WIDTH_PAD 42.0
#define GROWL_DESCRIPTION_HEIGHT_PAD 28.0
-#define GROWL_ROW_MINIMUM_HEIGHT 48.0
+int GROWL_ROW_MINIMUM_HEIGHT = 113.0;
#define GROWL_ROW_UNSELECTED_MAX_HEIGHT 62.0
#define GROWL_ROW_MAX_HEIGHT 113.0


Seems to correct much of the problem, at the cost of having the double-clicked
row in the rollup window seem too big sometimes (a way better outcome).
Obviously that patch is not correct.

I assume it relates to -heightForDescription called from -heightForRow and
this:

299 CGFloat result = bound.size.height + GROWL_DESCRIPTION_HEIGHT_PAD;
300 return (result > GROWL_ROW_MINIMUM_HEIGHT) ? result : GROWL_ROW_MINI
300 MUM_HEIGHT;

But I don't quite follow the logic of all that is going on there, especially
how -updateRowHeights recalculates this regularly.

Can anyone summarie how this code is intended to work? Thanks!

p.s.: Special thanks to Jérôme Chauvin for the buildable growl fork at
https://github.com/tazounet/growl. I'd still like to know what's fixed in
2.1.3, but this is hugely helpful!

--jh...@mit.edu
John Hawkinson