Why We Test

1 view

Skip to first unread message

unread,

Nov 21, 2012, 12:33:41 PM11/21/12

to groupiter-dev

Not to pick on Chip -- okay, to pick on Chip a little -- but last night's eleventh-hour deploy fail *did* cause unit tests to fail:

SessionsController

Has mix panel

should build a mixpanel object

Redirect after login

should redirect to invites if there are un-accepted invites (PENDING: No reason given)

should redirect to groups path if there are no un-accepted invites (PENDING: No reason given)

list_of_authorized_users

contains the contents of a config file

in staging

allows Chris to sign in (FAILED - 1)

is case-insensitive (FAILED - 2)

denies Adrian (FAILED - 3)

should allow Bertha because she was invited (FAILED - 4)

in beta

allows Chris to sign in (FAILED - 5)

is case-insensitive (FAILED - 6)

denies Adrian (FAILED - 7)

should allow Bertha because she was invited (FAILED - 8)

/signout

logs the user out

-- which means maybe we should make "cap deploy" go even slower and force a successful test run prior to deploying.

and/or put up a proper CI system (maybe Travis CI, or maybe the traditional "mac mini in the living room" solution).

- A

P.S. many Invite tests are also currently failing:

undefined method `token' for #<Invite:0x007ff25a9dd8f8>

# ./app/models/invite.rb:86:in `set_defaults'

and icons are kind of messed up too.

Reply all

Reply to author

Forward

0 new messages