documenting /src/foundation/gclib_jquery_extensions.js

0 views
Skip to first unread message

agent marmorkuchen

unread,
Mar 10, 2009, 12:21:07 PM3/10/09
to groundcrew-vie...@googlegroups.com
hello today...

looking at /src/foundation/gclib_jquery_extensions.js:

- $.template: is does not look like a jquery extension, no syntax like
$.fn.* or $.extend*. i also could not find an already existing function
$template in the jQuery documentation (or its search function is
bogus).
if it really is not a jQuery extension, perhaps put it into the
viewer, as it is used by it exensively? there are other
template-relatid functions in gclib_inflector, but it does not seem
right there.

- reveal stuff: why is the syntax different here? what is the difference
between $.fn.* and (function(){ ... $.fn.* ... })();? has this
something to do with keeping unreveal somewhat inaccessible from
outside?

- $.fn.disable: i suggest to include 'textarea' to the list of disabled
elements. the dialog to add a resource to be shared would benefit from
it, i reckon. alas, something seems broken there atm.
go to viewer.html#/share/:city/add
and the console log gives:

Viewer.go('/share/add')
resource find called with undefined!
window.fucker()...


- seemingly unused functions: show_dialog, scrollDown, showhide, forms,
fillout, clicks. make them comments? remove them?


bye,
marmorkuchen

--
_ ascii ribbon campaign .oOo. GCSd-s:+aC++ULB+++W++M+PS+++Y+
( )
X Trust your technolust!
/ \

Reply all
Reply to author
Forward
0 new messages