Hello! (and also a patch)

67 views
Skip to first unread message

dkate...@gmail.com

unread,
Jun 30, 2014, 1:37:04 PM6/30/14
to grive...@googlegroups.com
Hello everyone!

I've been using Grive for a while and I'm impressed how simple it was to set up. (User crontabs are a wonderful thing.)

Awhile ago I was a bit frustrated by how Grive wasn't syncing dotfiles. I ended up renaming my folder and using a symlink.

Eventually, I delved into my first major C++ project and git at the same time.

---

As for why this isn't a proper pull request:

1. I don't have a GitHub account
2. I don't want a GitHub account (I prefer Bazaar, honestly)
3. It's only one line of code

---

Here is the patch, as given by my 'git diff':

diff --git a/libgrive/src/drive/State.cc b/libgrive/src/drive/State.cc
index 2d1dc94..0d534f9 100644
--- a/libgrive/src/drive/State.cc
+++ b/libgrive/src/drive/State.cc
@@ -60,7 +60,7 @@ void State::FromLocal( const fs::path& p )

bool State::IsIgnore( const std::string& filename )
{
- return filename[0] == '.' ;
+ return (*filename == ".grive" || *filename == ".grive_state") ;
}

void State::FromLocal( const fs::path& p, Resource* folder )

---

Unfortunately I couldn't test it properly. I tried, honestly I did; but it couldn't find JSON-C, even after installing libjson-c-dev, libjson-c-doc, libjson-c2, libjson-c2-dbg.

I'm also unsure about the quality of the code, as (again) this is my first time working with major C++, and in particular with pointers.

Suggestions are welcome.

-- GalacticProportions

Reply all
Reply to author
Forward
0 new messages