Issue 33 in grit-i18n: Resource maps silently drop duplicated key field values

0 views
Skip to first unread message

grit...@googlecode.com

unread,
Aug 27, 2015, 5:51:00 PM8/27/15
to grit-de...@googlegroups.com
Status: Accepted
Owner: fla...@chromium.org
Labels: Type-Defect Priority-Medium

New issue 33 by fla...@chromium.org: Resource maps silently drop duplicated
key field values
https://code.google.com/p/grit-i18n/issues/detail?id=33

In resource_map.py the _FormatSource function builds a map from either path
or name to resource id. If it encounters duplicate values it silently skips
the duplicates. For name, duplicate values likely represent an error and
should be reported. For path, duplicate values mean we are packing the same
resource more than once (See
https://code.google.com/p/grit-i18n/issues/detail?id=27). This is not
necessarily an error but I feel that if we want to explicitly support this
we should include both resource ids in the "map" which would be more of a
multi-map at that point.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
Reply all
Reply to author
Forward
0 new messages