grit is now part of Chromium's repository and no longer pulled through DEPS

9 views
Skip to first unread message

Nico Weber

unread,
Nov 12, 2015, 8:14:48 PM11/12/15
to grit-developer, grit-...@googlegroups.com, Chromium-dev
Hi,

grit is now checked in to Chromium's repository. If you want to change grit, you now need a Chromium checkout to do so – on the flip side, no DEPS rolls need to happen after a grit change any more. Since all grit developers are Chromium developers in practice, this seemed like a good change. (The tracking bug was http://crbug.com/553682)

If you are using grit and don't want to check out all of Chromium, https://chromium.googlesource.com/chromium/src/tools/grit/ is a read-only mirror of the grit code in Chromium's repository. So you could pull from there.

Nico

Pavel Sergeev

unread,
Nov 12, 2015, 10:54:17 PM11/12/15
to tha...@chromium.org, grit-developer, grit-...@googlegroups.com, Chromium-dev
Where grit issues should be reported to: Chromium tracker or https://code.google.com/p/grit-i18n/issues?

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

Nico Weber

unread,
Nov 12, 2015, 11:35:35 PM11/12/15
to Pavel Sergeev, grit-developer, grit-...@googlegroups.com, Chromium-dev
On Thu, Nov 12, 2015 at 7:54 PM, Pavel Sergeev <dzh...@chromium.org> wrote:
Where grit issues should be reported to: Chromium tracker or https://code.google.com/p/grit-i18n/issues?

The grit-i18n one is on codesite which is going away soon, so I'd say on the Chromium tracker.

Jason Robbins

unread,
Nov 12, 2015, 11:37:34 PM11/12/15
to dzh...@chromium.org, Julie Parent, Nico Weber, grit-developer, grit-...@googlegroups.com, Chromium-dev
We could migrate your grit-i18n issues to bugs.chromium.org (monorail) if you like.

Thanks,
jason!

On Thu, Nov 12, 2015 at 7:54 PM, Pavel Sergeev <dzh...@chromium.org> wrote:
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.

Nico Weber

unread,
Nov 12, 2015, 11:41:59 PM11/12/15
to Jason Robbins, Pasha Sergeev, Julie Parent, grit-developer, grit-...@googlegroups.com, Chromium-dev
Since the code is now in the Chromium repo, having a separate bug tracker for that subdirectory seems a bit weird.

(And realistically, if someone wants to have some bug in grit fixed, they'll likely have to fix it themselves anyways.)

John Abd-El-Malek

unread,
Nov 13, 2015, 12:57:14 AM11/13/15
to Nico Weber, grit-developer, grit-...@googlegroups.com, Chromium-dev
Awesome, we should do more of this :)

--

Nick Carter

unread,
Nov 16, 2015, 3:14:24 PM11/16/15
to John Abd-El-Malek, Nico Weber, grit-developer, grit-...@googlegroups.com, Chromium-dev
Somehow, after trying to sync this morning, 'origin/master' on my main chromium checkout is now tracking grit-i18n.googlecode.com instead of the chromium mainline (my local branches are intact). Mentioning it here in case someone else hits it; seems not worth debugging unless widespread.

Steps that may have triggered this:
 - my initial 'git pull' (which would have pulled in new grit) failed the merge step because of a locked file in tools/grit.
 - after resetting, I did a 'gclient sync -f -D' on top of the old branch (with the old style grit).
 - 'git pull' failed again (with the locked file), so I moved tools/grit aside (to the parent of my src/ dir).

Ojan Vafai

unread,
Nov 20, 2015, 2:43:28 PM11/20/15
to j...@chromium.org, Nico Weber, grit-developer, grit-...@googlegroups.com, Chromium-dev
Yes please! Let's enforce good isolation more through include-guards and less through different repos wherever we can!

WC Leung

unread,
Nov 21, 2015, 11:59:46 PM11/21/15
to Chromium-dev, grit-de...@googlegroups.com, grit-...@googlegroups.com
Dear all,

    Today I want to commit my changes, and I've seen the following:
Changes to be committed:
  (use "git reset HEAD <file>..." to unstage)

        new file:   tools/grit/LICENSE
        new file:   tools/grit/codereview.settings
    Is it okay to delete that two files?

Regards,
WC Leung.

Nico Weber

unread,
Nov 22, 2015, 12:06:14 AM11/22/15
to WC Leung, Chromium-dev, grit-developer, grit-...@googlegroups.com
These two files were deleted here:

How are you trying to commit? How did you check out grit? Do you have a normal Chromium checkout?

--

WC Leung

unread,
Nov 22, 2015, 12:32:13 AM11/22/15
to Chromium-dev, lwc...@gmail.com, grit-de...@googlegroups.com, grit-...@googlegroups.com
Thanks! Apparently my recent "git rebase-update" and "gclient sync" failed to delete that two files, which is completely normal because we've moved grit from one repository to another. So I am content with manually deleting that two files myself.

BTW, what I refer as commit is a local commit, which will be uploaded by "git cl upload". No worries!

Regards,
WC Leung.
Reply all
Reply to author
Forward
0 new messages