Addressed comments in https://codereview.chromium.org/1676793002 https://codereview.chromium.org/1410023007/diff/1/grit/clique.py File grit/clique.py (right): https://codereview.chromium.org/1410023007/diff/1/grit/clique.py#newcode369 grit/clique.py:369: fallback_to_english=False, none_if_no_match=False): On 2015/10/27 19:25:13, Jamie wrote: > Optional: AFAICT, the final three parameters to this function are mutually > exclusive, with no documented behaviour if more than one is set to true. Perhaps > it would be better to replace them with an enum? The existing two flags are specified as booleans in the input grd files. Reverted the change in this file https://codereview.chromium.org/1410023007/diff/1/grit/clique.py#newcode405 grit/clique.py:405: # get a list of all messages that are missing translations. On 2015/10/27 19:25:13, Jamie wrote: > This comment is a bit misleading now that there's another fallback option. I > suggest rephrasing it so that it isn't specific to pseudotranslations and moving > it to just above the AddMissingTranslation call. Done. https://codereview.chromium.org/1410023007/diff/1/grit/format/chrome_messages_json.py File grit/format/chrome_messages_json.py (right): https://codereview.chromium.org/1410023007/diff/1/grit/format/chrome_messages_json.py#newcode38 grit/format/chrome_messages_json.py:38: if translation == None: On 2015/10/27 19:25:13, Jamie wrote: > Prefer "translation is not None" > (https://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=True/False_evaluations#True/False_evaluations) Done. https://codereview.chromium.org/1410023007/