[Blueprints] Public constructors for OrientDB/Neo4j Vertex/Edge and Neo4j transaction checking.

37 views
Skip to first unread message

Marko Rodriguez

unread,
Jun 4, 2012, 3:59:54 PM6/4/12
to gremli...@googlegroups.com
Hi,

I have made the constructors for OrientVertex/OrientEdge and Neo4jVertex/Neo4jEdge public as they were back in 1.x. This should make it easy for OrientDB's GREMLIN function and Neo4j's Gremlin plugin to go from their raw representation to Blueprints. Moreover, I believe this fixes the remote: issue OrientDB is having with Blueprints element serialization.



Next, I have made it such that checking elements for consistency with the current transaction is a boolean property that can be changed on Neo4jGraph via Neo4jGraph.checkElementsInTransaction.set(boolean). I've made this a thread local property where the default is to assume consistent transactions (see links below) --- thoughts?


Both of these updates are backwards compatible and should rectify the hiccups introduced with the release of Blueprints 2.x. Luca/Peter, can you please make sure this is sufficient for your two product's respective requirements? If this works for you two, then I can move forward with a 2.0.1 release of Blueprints.

** Pushed to master branch in GitHub and deployed to SonaType SNAPSHOT repo. **

Thank you,
Marko.

Luca Garulli

unread,
Jun 4, 2012, 6:24:10 PM6/4/12
to gremli...@googlegroups.com
Hi Marko,
by running the test with latest release I recognized what is missed: the public empty constructors:

 public OrientVertex() {
        super(null, new ODocument());
    }

and the same for the OrientEdge.

Adding these 2 constructors everything works!

You have a pull request ;-)

Thanks,
Lvc@

Marko Rodriguez

unread,
Jun 4, 2012, 6:30:33 PM6/4/12
to gremli...@googlegroups.com
Hey,

I just added your two constructors -- pushed to GitHub and deployed to SonaType SNAPSHOT repo.

Please let me know how it goes.

Thanks so much Luca,
Marko.

Luca Garulli

unread,
Jun 4, 2012, 6:39:14 PM6/4/12
to gremli...@googlegroups.com
Everything is ok.

Thanks,
Lvc@
Reply all
Reply to author
Forward
0 new messages