GM_registerMenuCommand with accelerators?

25 views
Skip to first unread message

Anthony Lieuallen

unread,
Mar 27, 2011, 5:40:20 PM3/27/11
to greasemonkey-dev
https://gist.github.com/889620

Does this work? I rather feel that it should display output when I
press "Ctrl+Shift+C" but .. it doesn't. To be safest, I tried this in
Firefox 3.6, GM 0.8. I keep going back and forth over whether I think
this feature ever worked. I thought it didn't for a long while, then I
did, now .. not so much again. I've tweaked the accelKey and the
modifiers to other values and I can't make it work at all anymore.

A test that functions correctly in 3.6+0.8 would be a good starting
point, or else I'm likely to start pulling my hair out.

sizzlemctwizzle

unread,
Mar 27, 2011, 7:44:26 PM3/27/11
to greasemonkey-dev
Nope I can't get the accelerators to work in FF 3.6 with GM 0.8 on Mac
OSX. Guess this feature never worked or at least hasn't for awhile.

Anthony Lieuallen

unread,
Mar 27, 2011, 11:11:04 PM3/27/11
to greasemo...@googlegroups.com
On 2011-03-27 7:44 PM, sizzlemctwizzle wrote:
> Nope I can't get the accelerators to work in FF 3.6 with GM 0.8 on Mac
> OSX. Guess this feature never worked or at least hasn't for awhile.

So, when I wrote
https://github.com/greasemonkey/greasemonkey/commit/4e5e3ecb4d02dea64c2a9add4eee4d239b8956dc
(Mar 13)
I had thought for quite some time that they never worked, and barely
gave a second thought to breaking them. I did reconsider it, however,
and threw together a quick test. When it worked I filed
https://github.com/greasemonkey/greasemonkey/issues#issue/1312 (Mar 16?)
-- then, and as pointed out earlier, I couldn't get them to work
anymore. Now I tried again, and they do -- kinda.

I'm seeing the same sort of problems as I was having with my re-written
version. Once a key works, loading pages or switching tabs has no
effect, that key is stuck, it won't run on another page. Closing the
tab that it's working for breaks it (forever I think, for all other tabs).

Again, this is 3.6 (Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US;
rv:1.9.2.16) Gecko/20110319 Firefox/3.6.16) + 0.8 (0.8.20100408.6). I
really don't like ruining backwards compatibility. But if it was always
broken, I'm less worried about breaking (/removing) a broken feature.

That all said, they're both open:
https://github.com/greasemonkey/greasemonkey/issues#issue/1312
for accelerator keys, and
https://github.com/greasemonkey/greasemonkey/issues#issue/1321
for the menu commands themselves.

Reply all
Reply to author
Forward
0 new messages