Another planar release ? :)

43 views
Skip to first unread message

Stuart Axon

unread,
Feb 8, 2016, 11:21:28 AM2/8/16
to Grease Users
Would it be possible to make a new release, incorporating the pull request to make things work under visual C ?


^ replacing trunc with floor certainly *seems* like it makes sense.


I guess, the bounding box methods on issue 1# could be useful too:

Casey Duncan

unread,
Feb 8, 2016, 11:30:06 AM2/8/16
to Grease Users
floor() and trunc() are not the same for negative numbers afaik. Is there no floor implementation at all? Seems strange.

As for the bounding box methods, they would need C implementations. Granted they are very simple.

I won't be making a release, but I'm happy to grant you admin access to pypi so that you can. But we need to make sure the changes  don't break anything of course.

-Casey

Stuart Axon

unread,
Feb 8, 2016, 6:10:16 PM2/8/16
to Grease Users
Ah, good catch :)

It looks like there is a version in cmath.h,  (though it's for C++)

Ah, I see - so each py function needs a C implementation.

I can certainly do releases, and merge changes coming in - though cant guarantee things won't break, as maths is a weak point of mine.
Reply all
Reply to author
Forward
0 new messages