[GrafX2] #126: Safety colors = yes is ignored by palette editor

[GrafX2]

#126: Safety colors = yes is ignored by palette editor
-------------------------+------------------------
Reporter: HoraK-FDF@… | Owner: pulkomandy
Type: defect | Status: new
Priority: major | Milestone:
Component: GrafX2 | Version: 2.7WIP
Keywords: |
-------------------------+------------------------
Hi,

to reproduce start gfx2 simply open palette editor press zap unused then
manually slide down the last three colors and all is black or if you
stopped earlier only certain details are remaining visible, by pressing ok
this state is also carried over and gfx2 stays that way.

tested with grafx2-2.7wip2732-issue_123

--
Ticket URL: <http://pulkomandy.tk/projects/GrafX2/ticket/126>
GrafX2 <http://pulkomandy.tk/projects/GrafX2>
The ultimate 256-color painting program

[GrafX2]

#126: Safety colors = yes is ignored by palette editor

--------------------------+------------------------

Reporter: HoraK-FDF@… | Owner: pulkomandy
Type: defect | Status: new
Priority: major | Milestone:
Component: GrafX2 | Version: 2.7WIP

Resolution: | Keywords:
--------------------------+------------------------

Comment (by yrizoud@…):

If the option was applied after every palette change, it would actually
cancel your action on colors used by the menus (if your image doesn't use
them yet), making them read-only. It would not be a good thing.

Note that the option is only meant as a safety, for example after a zap on
an empty image that would produce a full-black palette. In any other case,
Grafx2 will pick from whatever colors are available in the image's
palette. You can always re-create the default menu colors at any time by
pressing Backspace in the Palette screen (it will pick 4 unused slots,
starting at the end).

--
Ticket URL: <http://pulkomandy.tk/projects/GrafX2/ticket/126#comment:1>

[GrafX2]

#126: Safety colors = yes is ignored by palette editor

--------------------------+------------------------

Reporter: HoraK-FDF@… | Owner: pulkomandy
Type: defect | Status: new
Priority: major | Milestone:
Component: GrafX2 | Version: 2.7WIP

Resolution: | Keywords:
--------------------------+------------------------

Comment (by HoraK-FDF@…):

but should it not then at least reinsert the safety colors after pressing
ok?

--
Ticket URL: <http://pulkomandy.tk/projects/GrafX2/ticket/126#comment:2>

[GrafX2]

#126: Safety colors = yes is ignored by palette editor

--------------------------+------------------------

Reporter: HoraK-FDF@… | Owner: pulkomandy
Type: defect | Status: new
Priority: major | Milestone:
Component: GrafX2 | Version: 2.7WIP

Resolution: | Keywords:
--------------------------+------------------------

Comment (by PulkoMandy):

No, because you can really use all 256 colors for your picture. So it
should only apply them when you do something that could clear all colors
to black (zapping all colors, for example). Otherwise, the menu will just
pick 4 reasonable colors from the image palette.

--
Ticket URL: <http://pulkomandy.tk/projects/GrafX2/ticket/126#comment:3>

[GrafX2]

#126: Safety colors = yes is ignored by palette editor

--------------------------+------------------------

Reporter: HoraK-FDF@… | Owner: pulkomandy
Type: defect | Status: new
Priority: major | Milestone:
Component: GrafX2 | Version: 2.7WIP

Resolution: | Keywords:
--------------------------+------------------------

Comment (by HoraK-FDF@…):

but there are no 4 reasonable colors to pick anymore if you zapped and
slided the last four down.

--
Ticket URL: <http://pulkomandy.tk/projects/GrafX2/ticket/126#comment:4>

[GrafX2]

#126: Safety colors = yes is ignored by palette editor

--------------------------+------------------------

Reporter: HoraK-FDF@… | Owner: pulkomandy
Type: defect | Status: new
Priority: major | Milestone:
Component: GrafX2 | Version: 2.7WIP

Resolution: | Keywords:
--------------------------+------------------------

Comment (by Thomas Bernard):

in that case you press Backspace....

--
Ticket URL: <http://pulkomandy.tk/projects/GrafX2/ticket/126#comment:5>

[GrafX2]

#126: Safety colors = yes is ignored by palette editor

--------------------------+------------------------

Reporter: HoraK-FDF@… | Owner: pulkomandy
Type: defect | Status: new
Priority: major | Milestone:
Component: GrafX2 | Version: 2.7WIP

Resolution: | Keywords:
--------------------------+------------------------

Comment (by HoraK-FDF@…):

ok than but isn't the backspace feature a bit strange I mean if I press
backspace on a full palette with lots of colors that are useable for
safety colors It overwrites the last four ones should it not look first in
the palette if available colors are there near the menu colors instead of
searching unused colors and replace them?

--
Ticket URL: <http://pulkomandy.tk/projects/GrafX2/ticket/126#comment:6>

[GrafX2]

#126: Safety colors = yes is ignored by palette editor

--------------------------+------------------------

Reporter: HoraK-FDF@… | Owner: pulkomandy
Type: defect | Status: new
Priority: major | Milestone:
Component: GrafX2 | Version: 2.7WIP

Resolution: | Keywords:
--------------------------+------------------------

Comment (by Thomas Bernard):

so don't press backspace in that case...

--
Ticket URL: <http://pulkomandy.tk/projects/GrafX2/ticket/126#comment:7>

[GrafX2]

#126: Safety colors = yes is ignored by palette editor

--------------------------+------------------------

Reporter: HoraK-FDF@… | Owner: pulkomandy
Type: defect | Status: new
Priority: major | Milestone:
Component: GrafX2 | Version: 2.7WIP

Resolution: | Keywords:
--------------------------+------------------------

Comment (by Thomas Bernard):

by the way I think we should make sure the documentation is explicit about
the key shortcut in the palette editor and what are the consequences in
terms of menu colors.

what do you think of :

ESCAPE : cancel any palette modification and close palette dialog
ENTER : accept any palette modification and close palette dialog. Menu
colors are updated to best match
BACKSPACE : emergency key : assign 4 unused palette slots to menu colors.

(inline doc is also available online :
http://grafx2.gitlab.io/grafX2/htmldoc/grafx2_56.html )

--
Ticket URL: <http://pulkomandy.tk/projects/GrafX2/ticket/126#comment:8>

[GrafX2]

#126: Safety colors = yes is ignored by palette editor

--------------------------+------------------------

Reporter: HoraK-FDF@… | Owner: pulkomandy
Type: defect | Status: new
Priority: major | Milestone:
Component: GrafX2 | Version: 2.7WIP

Resolution: | Keywords:
--------------------------+------------------------

Comment (by Thomas Bernard):

see https://gitlab.com/GrafX2/grafX2/merge_requests/212

--
Ticket URL: <http://pulkomandy.tk/projects/GrafX2/ticket/126#comment:9>

[GrafX2]

#126: Safety colors = yes is ignored by palette editor

--------------------------+------------------------

Reporter: HoraK-FDF@… | Owner: pulkomandy
Type: defect | Status: new

Priority: major | Milestone: 2.7

Component: GrafX2 | Version: 2.7WIP
Resolution: | Keywords:
--------------------------+------------------------

Changes (by Thomas Bernard):

* milestone: => 2.7


Comment:

@yri...@gmail.com @Hora...@web.de are you happy with the help
improvement in
https://gitlab.com/miniupnp/grafX2/commit/3a9d0a1a9b7246d070cdc5c376ca0976ca665d61
?

--
Ticket URL: <http://pulkomandy.tk/projects/GrafX2/ticket/126#comment:10>

[GrafX2]

#126: Safety colors = yes is ignored by palette editor

--------------------------+------------------------

Reporter: HoraK-FDF@… | Owner: pulkomandy
Type: defect | Status: new

Priority: major | Milestone: 2.7
Component: GrafX2 | Version: 2.7WIP
Resolution: | Keywords:
--------------------------+------------------------

Comment (by yrizoud@…):

Fine by me. I tested with long shortcut names, it still fits.

--
Ticket URL: <http://pulkomandy.tk/projects/GrafX2/ticket/126#comment:11>

[GrafX2]

#126: Safety colors = yes is ignored by palette editor

--------------------------+------------------------
Reporter: HoraK-FDF@… | Owner: pulkomandy
Type: defect | Status: closed
Priority: major | Milestone: 2.10
Component: GrafX2 | Version: 2.7
Resolution: fixed | Keywords:
--------------------------+------------------------
Changes (by PulkoMandy):

* resolution: => fixed
* status: new => closed

Comment:

Fixed in 7e947dc0110718762f946c1cd2cd4597eab30714.

It will try to find 4 unused colors to inject the safety colors in, if no
suitable colors are available. I think this is safe, and if it creates
problems, the safety colors option can be disabled from the settings.
--
Ticket URL: <http://pulkomandy.tk/projects/GrafX2/ticket/126#comment:16>