[GrafX2] #105: minimize the number of .C files that include <windows.h>

5 views
Skip to first unread message

GrafX2

unread,
Feb 2, 2019, 10:27:32 AM2/2/19
to gra...@googlegroups.com
#105: minimize the number of .C files that include <windows.h>
----------------------------+----------------------------
Reporter: Thomas Bernard | Owner: Thomas Bernard
Type: enhancement | Status: assigned
Priority: minor | Milestone: 2.7
Component: GrafX2 | Version: 2.6
Keywords: win32 |
----------------------------+----------------------------
<windows.h> pollutes the global namespace a lot
(see http://pulkomandy.tk/projects/GrafX2/ticket/99)

--
Ticket URL: <http://pulkomandy.tk/projects/GrafX2/ticket/105>
GrafX2 <http://pulkomandy.tk/projects/GrafX2>
The ultimate 256-color painting program

GrafX2

unread,
May 21, 2019, 10:50:56 AM5/21/19
to gra...@googlegroups.com
#105: minimize the number of .C files that include <windows.h>
-----------------------------+----------------------------
Reporter: Thomas Bernard | Owner: Thomas Bernard
Type: enhancement | Status: assigned
Priority: minor | Milestone: 2.7
Component: GrafX2 | Version: 2.6
Resolution: | Keywords: win32
-----------------------------+----------------------------

Comment (by Thomas Bernard):

and also there is our own windows.h... shouldn't us rename it to
gfx2windows.h or something ?
{{{
#include <windows.h>
#include "windows.h"
}}}

--
Ticket URL: <http://pulkomandy.tk/projects/GrafX2/ticket/105#comment:1>

GrafX2

unread,
May 24, 2019, 5:10:20 AM5/24/19
to gra...@googlegroups.com
#105: minimize the number of .C files that include <windows.h>
-----------------------------+----------------------------
Reporter: Thomas Bernard | Owner: Thomas Bernard
Type: enhancement | Status: assigned
Priority: minor | Milestone: 2.7
Component: GrafX2 | Version: 2.6
Resolution: | Keywords: win32
-----------------------------+----------------------------

Comment (by Thomas Bernard):

there is OS dependent code in many places we'll need to put some of theses
in separate .c files.
I have already successfully removed <windows.h> from const.h ;)

https://gitlab.com/GrafX2/grafX2/merge_requests/204

--
Ticket URL: <http://pulkomandy.tk/projects/GrafX2/ticket/105#comment:2>

GrafX2

unread,
Apr 21, 2020, 5:59:43 PM4/21/20
to gra...@googlegroups.com
#105: minimize the number of .C files that include <windows.h>
-----------------------------+----------------------------
Reporter: Thomas Bernard | Owner: Thomas Bernard
Type: enhancement | Status: closed
Priority: minor | Milestone: 2.8
Component: GrafX2 | Version: 2.6
Resolution: fixed | Keywords: win32
-----------------------------+----------------------------
Changes (by Thomas Bernard):

* status: assigned => closed
* resolution: => fixed


--
Ticket URL: <http://pulkomandy.tk/projects/GrafX2/ticket/105#comment:4>
Reply all
Reply to author
Forward
0 new messages