Gradle wrapper

6 views
Skip to first unread message

Marcin Erdmann

unread,
Oct 6, 2011, 2:55:49 PM10/6/11
to gradle-android-p...@googlegroups.com
Dear all,

Is there any particular reason that you are not using gradle wrapper for
building the plugin? It would be nice not to have to know which exact
version of gradle I need to build it. I have some old (0.9.1) version
installed locally and I cannot build it anymore but if only the plugin
used gradlew I could use it and it would download the needed version for me.

Do you have anything against me adding gradle wrapper as a part of my
pull request?

Marcin Erdmann

P.s. Btw, which version should I use actually?

Ladislav Thon

unread,
Oct 6, 2011, 3:19:59 PM10/6/11
to gradle-android-p...@googlegroups.com
Is there any particular reason that you are not using gradle wrapper for building the plugin?

I guess it's just that nobody needed it yet. I personally don't like the idea of Gradle wrapper much, but it looks like it is The Recommended Way, so I personally have no objections against adding it.

P.s. Btw, which version should I use actually?

Currently, you should use 1.0-m3 (as m4 has some major performance issues -- but some people use m4 anyway).

LT

Marcin Erdmann

unread,
Oct 6, 2011, 3:31:01 PM10/6/11
to gradle-android-p...@googlegroups.com
On 10/06/2011 09:19 PM, Ladislav Thon wrote:
> Is there any particular reason that you are not using gradle wrapper
> for building the plugin?
>
>
> I guess it's just that nobody needed it yet. I personally don't like the
> idea of Gradle wrapper much, but it looks like it is The Recommended
> Way, so I personally have no objections against adding it.

Ok, I will include it in my pull request then.

>
> P.s. Btw, which version should I use actually?
>
>
> Currently, you should use 1.0-m3 (as m4 has some major performance
> issues -- but some people use m4 anyway).

Unfortunately you're wrong:). I've just learned that Matthias modified
the build so that it's milestone-4 dependent - he's using output
property of source sets which was added in m4. That's why I've set
gradle version to m4 for the wrapper.

Marcin

Ladislav Thon

unread,
Oct 6, 2011, 3:40:39 PM10/6/11
to gradle-android-p...@googlegroups.com
Unfortunately you're wrong:). I've just learned that Matthias modified the build so that it's milestone-4 dependent - he's using output property of source sets which was added in m4. That's why I've set gradle version to m4 for the wrapper.

Hah, true! I remember messing with this myself too... hopefully, m5 should be released soon.

LT
Reply all
Reply to author
Forward
0 new messages