Issue 12 in gpapers: Program hangs at DOI dialog [fix included]

[codesite...@google.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 12 by 98310b...@gmail.com: Program hangs at DOI dialog [fix
included]
http://code.google.com/p/gpapers/issues/detail?id=12

What steps will reproduce the problem?
1. Open gpapers
2. Select File->Import DOI...
3. Enter a valid DOI and press OK

What is the expected output? What do you see instead?

The dialog should close and the paper referred to by the DOI should be
retrieved in the background. Instead, the dialog stops responding to
button presses. The program must then be killed from the system monitor.

What version of the product are you using? On what operating system?

I am using a copy pulled via mercurial on 7/25/2012 (Revision
ID:1638d25e2632) which I installed on Ubuntu 12.04. I use Python version
2.7.3

Please provide any additional information below.

I noticed a NameError in the import_from_url method in
gpapers.importer.__init__.py, so I did a little debugging and found that
the package-global variable 'active_threads' hadn't been declared global in
that method. I fixed the problem and now the dialog works as expected. I
have attached a patch file which contains the required changes.


Attachments:
doi_fix.patch 3.5 KB

[codesite...@google.com]

Updates:
Status: Fixed

Comment #1 on issue 12 by marcelCo...@gmail.com: Program hangs at DOI

dialog [fix included]
http://code.google.com/p/gpapers/issues/detail?id=12

This issue was closed by revision ed11b79da7d8.

[codesite...@google.com]

Comment #2 on issue 12 by marcelCo...@gmail.com: Program hangs at DOI

dialog [fix included]
http://code.google.com/p/gpapers/issues/detail?id=12

Many thanks for the report and the patch, I applied the necessary changes.
The whole "active_threads" issue is still quite hacky and should be
replaced with an object getting notified of running tasks...