Issue 16 in gpapers: Paper deselected on viewing full text [fix included]

18 views
Skip to first unread message

codesite...@google.com

unread,
Aug 18, 2012, 6:38:48 PM8/18/12
to gpapers...@googlegroups.com
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 16 by 98310b...@gmail.com: Paper deselected on viewing full text
[fix included]
http://code.google.com/p/gpapers/issues/detail?id=16

What steps will reproduce the problem?
1. Select a paper with a full-text PDF available.
2. Open the PDF.
3. Alt-Tab back to the gpapers window or close the PDF

What is the expected output? What do you see instead?

The paper should remain selected, but it gets unselected within a few
seconds of opening the PDF.

What version of the product are you using? On what operating system?
I am using the latest git revision (7728031bc509) on Ubuntu 12.04.

Please provide any additional information below.

As far as I can tell, this happens because the paper's "read count"
attribute gets updated when a user opens the associated PDF. I'm guessing
that this change causes the list of papers to refresh and clear the
selection.

My patch just manually re-selects the current paper after updating
the "read count". I'm not sure if there's a better way to do this--I'm a
GTK n00b and I'm not particularly well-versed in how the tree widget works.


Attachments:
paper_deselect_fix.patch 976 bytes

codesite...@google.com

unread,
Aug 24, 2012, 5:01:30 PM8/24/12
to gpapers...@googlegroups.com
Updates:
Status: Fixed

Comment #1 on issue 16 by marcelCo...@gmail.com: Paper deselected on
This issue was closed by revision 5882d21ea5cf.

codesite...@google.com

unread,
Aug 24, 2012, 5:03:44 PM8/24/12
to gpapers...@googlegroups.com

Comment #2 on issue 16 by marcelCo...@gmail.com: Paper deselected on
Thanks (again) for your report. It is also a workaround, but instead of
re-selecting the paper I now temporarily unconnect the post_save signal.
But the signalling of updates remains messy and needs some basic overhaul...

Reply all
Reply to author
Forward
0 new messages