Issue 14 in gpapers: Entering bookmarks and paper notes is laggy [fix included]

[codesite...@google.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 14 by 98310b...@gmail.com: Entering bookmarks and paper notes is
laggy [fix included]
http://code.google.com/p/gpapers/issues/detail?id=14

What steps will reproduce the problem?
1. Display a paper in gpapers
2. Begin typing in the paper notes text box.

What is the expected output? What do you see instead?
The bookmark or note should be saved to the paper as I type. Instead, the
save operation takes so long that it is difficult to type. If the general
paper notes are being edited, the paper gets de-selected every time a
single letter is saved.

What version of the product are you using? On what operating system?
I am using the latest version from git (Revision 1dbb66ebecfb) on Ubuntu
12.04.

Please provide any additional information below.

I have included a patch which makes a number of changes:
1. Notes and bookmarks are no longer saved automatically when the text box
is edited.

2. A save button appears next to the 'add bookmark' button when
appropriate. When clicked, it saves the current text to the paper notes or
a bookmark if one is selected.

3. When a paper note is saved, the current paper is manually re-selected to
prevent it from being unselected. This isn't a permanent solution, but it
works for now.


I realize this isn't the sort of functionality you originally intended, but
I thought this might work better for people like me with slow computers.

Attachments:
paper_notes_fixes.patch 4.7 KB

[codesite...@google.com]

Updates:
Status: Accepted
Owner: marcelCo...@gmail.com

Comment #1 on issue 14 by marcelCo...@gmail.com: Entering bookmarks and

paper notes is laggy [fix included]
http://code.google.com/p/gpapers/issues/detail?id=14

Thanks for the report and the fix. The note/bookmark saving is certainly
far from optimal, I think I already had some "FIXME" comments in the code
about that.. I'll have a look at your patch tonight -- I'd prefer not to
have another button, though. Maybe simply slowing down the saving so that
it does not save on every keystroke is sufficient?

[codesite...@google.com]

Updates:
Status: Fixed

Comment #2 on issue 14 by marcelCo...@gmail.com: Entering bookmarks and

paper notes is laggy [fix included]
http://code.google.com/p/gpapers/issues/detail?id=14

This issue was closed by revision 79b57a3eddd5.

[codesite...@google.com]

Comment #3 on issue 14 by marcelCo...@gmail.com: Entering bookmarks and

paper notes is laggy [fix included]
http://code.google.com/p/gpapers/issues/detail?id=14

Hi, I ended up refactoring the code and went a bit of different approach
than your patch in the end... The issue with the unselection was a silly
one and had to do with an "post_save" signal sent after editing the note,
leading to an update of the complete library display, basically :-/ For the
saving after every keystroke, I changed it so that now a bookmark or note
is only saved if you navigate away from it (select a different paper, a
different note, etc.) or when the program exits -- this should make it
usable again, I hope! Testing is appreciated, though.

Thanks again for reporting and looking into this.

[codesite...@google.com]

Comment #4 on issue 14 by 98310b...@gmail.com: Entering bookmarks and paper

notes is laggy [fix included]
http://code.google.com/p/gpapers/issues/detail?id=14

Your fix looks good--I like that it keeps the original auto-save
functionality intact.

There is one problem remaining, though. I just noticed in testing that
page notes don't get saved if you open a paper with two notes, change one,
and then select the other one. I haven't had a chance to figure out why,
though.