access to remote IPv4 or IPv6 address?

[David Birdsong]

I'm implementing access logs that would be much better if I could log the remote IPv4 or IPv6 addresses that Transport ends up resolving and connecting to (or re-using.)

I'm already providing my own ```Tr``` to the proxy so I can keep a running counter on new connections created with the purpose of deriving a metric around connection re-use:

https://gist.github.com/davidbirdsong/bfb6c2a6086ec75c6c3a

...but I haven't figured out how to associate a request to a net.Conn.

Does anybody have any suggestions on how to tie a request to a net.Conn?

[Elazar Leibovich]

You can put a specific roundtripper in the context. This roundtripper would tell you which connection to use.

Something like:

proxy.OnRequest().DoFunc(func(req *http.Request, ctx *goproxy.Context) (*http.Request, *http.Response) {

    ctx.RoundTripper = createRoundTripper()

    return req, nil

}

--
You received this message because you are subscribed to the Google Groups "goproxy-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to goproxy-dev...@googlegroups.com.
To post to this group, send email to gopro...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/goproxy-dev/660c3f15-e8e4-4f02-af86-1220ef5fe973%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[David Birdsong]

Of course!

I was looking right at it and not seeing that it was possible to override on a per-request/per-context basis. This makes it possible right? https://github.com/elazarl/goproxy/blob/master/ctx.go#L37

[Elazar Leibovich]

Exactly. That's was the reason for adding this field in Context.

To view this discussion on the web visit https://groups.google.com/d/msgid/goproxy-dev/CABJfL5gqsuPWSnJ6X4oymSDPUtPr3tiCtheOm0zJN%3DypXTfRcw%40mail.gmail.com.

[David Birdsong]

Hmm, so there's still a big challenge here.

I'll continue to want to use a single instance of *http.Transport to leverage it's connection tracking and reuse functionality. I'm thinking I'll need a per-request closure to share data w/ my implementation of Dialer, but to make use of the single *http.Transport on the proxy instance, I'd need to reassign it's Dial member to my Dialer implementation which would be very thread-unsafe.

[Patrick Mézard]

On 14/04/15 20:57, David Birdsong wrote:
> Of course!
>
> I was looking right at it and not seeing that it was possible to
> override on a per-request/per-context basis. This makes it possible
> right? https://github.com/elazarl/goproxy/blob/master/ctx.go#L37

FWIW, the httpdumper example demonstrates how to do that:

https://github.com/elazarl/goproxy/blob/master/examples/goproxy-httpdump/httpdump.go#L254

--
Patrick Mézard

[David Birdsong]

great, this helps!

 

--
Patrick Mézard