Issue 335 in googletransitdatafeed: Transxchange2GoogleTransit doesn't follow best practise in use of types and doesn't use generics

1 view
Skip to first unread message

googletran...@googlecode.com

unread,
Jun 8, 2012, 6:08:24 AM6/8/12
to googletran...@googlegroups.com
Status: New
Owner: ----

New issue 335 by scottish...@gmail.com: Transxchange2GoogleTransit doesn't
follow best practise in use of types and doesn't use generics
http://code.google.com/p/googletransitdatafeed/issues/detail?id=335

Transxchange2GoogleTransit uses HashMap and ArrayList in method signatures
and field variables rather than using Map and List as is best practice.
It doesn't use generics at all which results in casts all over the place
and reduces type safety (I found one type safety bug in a dumpValues
method).

I have a patch which addresses this problem by fixing all the cases.


Attachments:
0003-Fix-Types.patch 143 KB

Reply all
Reply to author
Forward
0 new messages