Compile error when build googletest with Cmake on Ubuntu 14.04 for Android cross compile

[Jin Li]

Hey,

I saw following error messages when build gtest.cc on docker (Ubuntu 14.04) for Android cross compile. Please check if the attached patch makes sense.

Thanks,

Frank

[docker] [ 88%] Building CXX object third_party/googletest/build/googletest/CMakeFiles/gtest.dir/src/gtest-all.cc.o

[docker] In file included from /tmp/aws-iot-device-sdk-cpp/build-ndk/third_party/googletest/src/googletest/src/gtest-all.cc:41:

/tmp/aws-iot-device-sdk-cpp/build-ndk/third_party/googletest/src/googletest/src/gtest.cc:1952:21: error: implicit conversion changes signedness: 'const wchar_t' to 'wint_t' (aka 'unsigned int') [-Werror,-Wsign-conversion]

    left = towlower(*lhs++);

           ~~~~~~~~ ^~~~~~

/tmp/aws-iot-device-sdk-cpp/build-ndk/third_party/googletest/src/googletest/src/gtest.cc:1953:22: error: implicit conversion changes signedness: 'const wchar_t' to 'wint_t' (aka 'unsigned int') [-Werror,-Wsign-conversion]

    right = towlower(*rhs++);

            ~~~~~~~~ ^~~~~~

[Gennadiy Civil]

Thank you for this. If you have a patch to consider please submit a proper PR.

Thanks again

G