Make check fails on QNX Neutrino 6.4.1

[Martin Gagnon]

Just built gtest 1.4.0 from the .tar.gz package on a QNX Neutrino 6.4.1 system.

# uname -a

QNX VM-QNX641 6.4.1 2009/05/20-17:35:56EDT x86pc x86

configure: ran without any options, exit status=0

make: exit status=0

make check: exit status=2

See attached file for details.

Is there something I should change in the build to make it pass the tests?

Let me know if I can be of any help testing on this OS.

Thank you,

Martin

[Vlad Losev]

Hi Martin,

The Google Test library itself is correct. The problem lies with the tests that are failing. They assume that that Google Test supports death test on your platform, which is not the case. I have attached a patch that fixes that incorrect assumption. Can you please re-run make test with it applied and see whether they still fail? Please note – the patch is based against svn head, not against release 1.4.0.

Thank you,

Martin

To unsubscribe from this group, send email to googletestframework+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.

Thanks,
Vlad

[Vlad Losev]

[adding the list]

Hi Martin,

Apparently, this patch fails if applied to 1.4. Please try applying it to svn head. After checkout, just apply the patch, run 'autoreconf -if' from the Google Test's root directory and then build as usual. I suggest using -p2 flag with patch if you are running it from the test directory.

On Fri, Mar 26, 2010 at 8:05 PM, Martin Gagnon <martin....@gmail.com> wrote:

Hi Vlad,

I'm glad to hear that!

I may need some assistance to apply the patch though.
I never patched before but since all the diffs apply to files in the 'test' dir I figured out I could simply do:

# cp death_test.patch /root/gtest/gtest-1.4.0/test/
# cd /root/gtest/gtest-1.4.0/test/
# patch < death_test.patch
patching file gtest_filter_unittest.py
Hunk #1 succeeded at 77 (offset -31 lines).
Hunk #2 succeeded at 106 (offset -31 lines).
Hunk #3 succeeded at 126 (offset -31 lines).
Hunk #4 succeeded at 149 with fuzz 2 (offset -34 lines).
Hunk #5 succeeded at 417 (offset -31 lines).
Hunk #6 succeeded at 478 (offset -31 lines).
Hunk #7 succeeded at 486 (offset -31 lines).
Hunk #8 succeeded at 504 (offset -31 lines).
Hunk #9 succeeded at 562 (offset -31 lines).
patching file gtest_help_test.py
Hunk #1 FAILED at 51.
Hunk #2 succeeded at 100 with fuzz 2 (offset -11 lines).
1 out of 2 hunks FAILED -- saving rejects to file gtest_help_test.py.rej
patching file gtest_help_test_.cc
#
================================

Note that I never ran make test from the source dir but rather make check from the build dir.

What should I do after the patch is applied to the source dir?

Would it be simpler if I checked-out the svn head?

Thank you,

Martin

Regards,
Vlad

[Martin Gagnon]

Vlad,

On Thu, Mar 25, 2010 at 7:01 PM, Vlad Losev <vlad...@gmail.com> wrote:

Hi Martin,

On Wed, Mar 24, 2010 at 4:47 AM, Martin Gagnon <martin....@gmail.com> wrote:

Just built gtest 1.4.0 from the .tar.gz package on a QNX Neutrino 6.4.1 system.

# uname -a

QNX VM-QNX641 6.4.1 2009/05/20-17:35:56EDT x86pc x86

configure: ran without any options, exit status=0

make: exit status=0

make check: exit status=2

See attached file for details.

Is there something I should change in the build to make it pass the tests?

Let me know if I can be of any help testing on this OS.

The Google Test library itself is correct. The problem lies with the tests that are failing. They assume that that Google Test supports death test on your platform, which is not the case. I have attached a patch that fixes that incorrect assumption. Can you please re-run make test with it applied and see whether they still fail? Please note – the patch is based against svn head, not against release 1.4.0.

See attached file for 'make check' output.

 

Thank you,

Martin

To unsubscribe from this group, send email to googletestframework+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.

Thanks,
Vlad

Thanks,

Martin

[Vlad Losev]

HI Martin,

Google Test has implemented thread safety for systems that support pthreads. It looks like QNX does have pthreads support but it does not work well enough for us or Google Test is setting up pthreads flags incorrectly for QNX. Please try invoking configure with the "--with_pthreads=no" flag.

Thanks,

Vlad

[Vlad Losev]

Hi Martin,

We have updated the affected tests. If you now check out revision 411, build it with CMake and run ctest, all tests should pass.

Regards,
Vlad