ASSERT_EQ and ASSERT_NE rationale

[Gregory Pakosz]

Hello,

What's the rational behind having ASSERT_EQ allowing tests like
ASSERT_EQ(NULL, somePointer); though disallowing ASSERT_NE(NULL,
somePointer); ?

From what I see, the implementation of ASSERT_EQ relies
on ::testing::internal::EqHelper<GTEST_IS_NULL_LITERAL_(expected)
>::Compare but ASSERT_NE uses ::testing::internal::CmpHelperNE.

With MSVC2005, ASSERT_NE(NULL, somePointer); fails to compile when
trying to instantiate CmpHelperNE<int, void*> with a C2040 error:
http://msdn.microsoft.com/en-us/library/kb3dky0e.aspx

Thank you,
Gregory

[Tor Didriksen]

please see

http://code.google.com/p/googletest/wiki/GoogleTestFAQ#Why_does_Google_Test_support_EXPECT_EQ%28NULL,_ptr%29_but_not_EXPECT

-- didrik

[Gregory Pakosz]

>
> please see
>
> http://code.google.com/p/googletest/wiki/GoogleTestFAQ#Why_does_Googl...
>
> -- didrik

Hello didrik,

Thank you for that quick answer.

To my defense, I did opened the FAQ but searched for "ASSERT_NE" in
the page which gave not found (yeah it was only the 4th item in the
toc though).

May I suggest to change the title of the item to:

"Why does Google Test support EXPECT_EQ(NULL, ptr) and ASSERT_EQ(NULL,
ptr) but not EXPECT_NE(NULL, ptr) and ASSERT_NE(NULL, ptr)?"

Regards,
Gregory

[Zhanyong Wan (λx.x x)]

Thanks for the suggestion. Done.

--
Zhanyong