MSVC6 Port

[kyos...@gmail.com]

Reviewers: ,

Description:
Hi, I'm porting googletest to MSVC6 for some of my legacy projects.
As you know VC6 is now so old, but I think before upgrade to newer
version of IDE, it might helpful to have tests.

I hope someone to review this port.
Currently, gtest_unittest.cc passes. How should I do next?

Related issue.
http://code.google.com/p/googletest/issues/detail?id=150

Thanks.

Please review this at http://codereview.appspot.com/63192

Affected files:
include/gtest/gtest-message.h
include/gtest/gtest.h
include/gtest/gtest_pred_impl.h
include/gtest/internal/gtest-internal.h
include/gtest/internal/gtest-port.h
include/gtest/internal/gtest-string.h
msvc6/gtest.dsp
msvc6/gtest.dsw
msvc6/gtest_main.dsp
msvc6/gtest_unittest.dsp
src/gtest-filepath.cc
src/gtest-internal-inl.h
src/gtest.cc
test/gtest-message_test.cc
test/gtest_unittest.cc

[Zhanyong Wan (λx.x x)]

Wow, 2182 lines of change already. I admire your enthusiasm. :-)

I took a cursory look at the patch. Sadly, I'm worried that it will
make the code base much harder to maintain. The patch uses many #ifs,
and sometimes it has to settle for reduced functionality or a
different syntax compared with existing constructs. Also, the changes
are spread out into many files, instead of being local.

While I appreciate your effort and willingness to contribute back to
the user community, given the relatively small number of VC 6 users
today, and the fact that the number will only go down in the future,
I'm inclined to not accept this patch into the official gtest source
tree. :-(

Having said that, it might make sense to check in the patch somewhere,
perhaps in a branch called unsupported_vc6_port, such that other VC 6
users can still benefit from your work. The "unsupported" prefix
should make it clear that we don't have the resources to officially
support it and the users are expected to help themselves.

What do you and other people think? Thanks,

--
Zhanyong

[Zhanyong Wan (λx.x x)]

Hi all,

I've created a new branch
(http://code.google.com/p/googletest/source/browse/#svn/branches/unsupported-vc6-port)
and committed the patch into it. Thanks,

2009/6/4 Zhanyong Wan (λx.x x) <w...@google.com>:

--
Zhanyong