Adding QNX as predefined platform in gtest-port.h

[Haruka Iwao]

Hello,

I am using google test on QNX platform.
Currently gtest-port.h doesn't include macros for QNX so I manually
define some necessary definitions such as GTEST_USE_OWN_TR1_TUPLE,
GTEST_HAS_PTHREAD, etc.

Will a patch to support QNX as predefined platform likely be accepted?
If so, I'd make and submit a patch.

Thanks.

[Vlad Losev]

Yes, we do accept patches. Please see http://code.google.com/p/googletest/wiki/DevGuide#Contributing_Code for instructions on how to contribute. Is this patch will be applicable to the OS in general or to a particular combination of compiler/standard library?

Thanks.

[Haruka Iwao]

Hello,

On 5月20日, 午後5:31, Vlad Losev <v...@losev.com> wrote:
> Yes, we do accept patches. Please seehttp://code.google.com/p/googletest/wiki/DevGuide#Contributing_Codefor
> instructions on how to contribute. Is this patch will be applicable to the
> OS in general or to a particular combination of compiler/standard library?

Thanks for the info.
I'll read the guide and try to make a patch.
It should work on QNX and QNX qcc compiler, which is based on gcc and
customized by QNX Software.
However I only have QNX Momentics (toolkit, compiler + IDE) version
4.7 so I'm not sure it work on earlier versions.
Intel also has a compiler for QNX but I cannot test on it because I
don't have it.
I *think* Intel's compiler is also based on gcc so my patch should
work on both compiler... but no proof.

[Haruka Iwao]

> I *think* Intel's compiler is also based on gcc so my patch should
> work on both compiler... but no proof.

Sorry, this is not correct.
Intel C++ compiler is made from their own code.
According to their document,
http://software.intel.com/sites/products/collateral/hpc/compilers/qnx_compiler_indepth.pdf
they claim it is compatible with gcc, but I think there are some
differences.

--
Haruka

[Haruka Iwao]

Hello,

I posted two patches on Rietveld. What should I do next?

http://codereview.appspot.com/4517138/

http://codereview.appspot.com/4568066/

[Vlad Losev]

HI Haruka,

I will post some comments for the first patch shortly. The second patch looks good as is. Once we accept the patches, we'll merge them into the trunk and they will be available from the svn head. They will be picked up in the next release although that release is likely far off.

Regards,

Vlad

[Vlad Losev]

Haruka,

You patch has landed in the repository in revision 586.

Thanks for the contribution!

- Vlad

[Haruka Iwao]

Hi Vlad,

Thank you for improving and accepting the patch.

I confirmed its landing.

However, I don't see http://codereview.appspot.com/4568066/ in the trunk.

What about this patch?

-- 

Haruka

[Vlad Losev]

I'll do this separately.

[Vlad Losev]

Hi Haruka 

The http://codereview.appspot.com/4568066/ fix is is now in SVN, revision 587.

Regards,

Vlad