--gtest_print_time option should be switched on by default
Alexander Demin
I personally prefer always have '--gtest_print_time' option on by
default all the time. I do not have even one reason to switch it off
anytime -- no overhead and just a bit more characters on each output
line, and I need it in 99% cases. In 99% I prefer to know test timing.
That's why all my gtest main()s explicitly inject '--gtest_print_time'
into the argument list.
I was wondering am I alone? ;-) Maybe it should be great to have this
option on by default rather than off.
Regards,
Alexander
Zhanyong Wan (λx.x x)
testing::GTEST_FLAG(print_time) = true;
before calling InitGoogleTest() in main().
I shall add this to the wiki.
My experience is that most of the time people don't care about the
timing. The timing is useful when you have some unusually slow tests
and you want to identify them. Otherwise, it just clutters the
output. Therefore I'd like to keep it off by default.
--
Zhanyong
Alexander Demin
Alexander
Zhanyong Wan (λx.x x)
> You can easily change the default of the gtest flags in your tests. Just write
>
> testing::GTEST_FLAG(print_time) = true;
>
> before calling InitGoogleTest() in main().
>
> I shall add this to the wiki.
>
> My experience is that most of the time people don't care about the
> timing. The timing is useful when you have some unusually slow tests
> and you want to identify them. Otherwise, it just clutters the
> output. Therefore I'd like to keep it off by default.
>
> On Sun, Jan 18, 2009 at 2:13 AM, Alexander Demin <ade...@gmail.com> wrote:
>>
>> Hi,
>>
>> I personally prefer always have '--gtest_print_time' option on by
>> default all the time. I do not have even one reason to switch it off
>> anytime -- no overhead and just a bit more characters on each output
>> line, and I need it in 99% cases. In 99% I prefer to know test timing.
>> That's why all my gtest main()s explicitly inject '--gtest_print_time'
>> into the argument list.
>>
>> I was wondering am I alone? ;-) Maybe it should be great to have this
>> option on by default rather than off.
>>
>> Regards,
>> Alexander
>>
>
>
>
> --
> Zhanyong
>
--
Zhanyong
Alexander Demin
only for the trunk?
Alexander
On Jan 20, 6:57 pm, Zhanyong Wan (λx.x x) <w...@google.com> wrote:
> On Sun, Jan 18, 2009 at 3:33 PM, Zhanyong Wan (λx.x x) <w...@google.com> wrote:
>
> > You can easily change the default of the gtest flags in your tests. Just write
>
> > testing::GTEST_FLAG(print_time) = true;
>
> > before calling InitGoogleTest() in main().
>
> > I shall add this to the wiki.
>
Zhanyong Wan (λx.x x)
>
> Unfortunately "print_time" is not declared in the headers. Is this
> only for the trunk?
Uh, I guess we forgot to declare it. You can declare it yourself, but
it's better to declare it in gtest.h. Would you like to submit a
patch for review? See the DevGuide wiki for instructions if you are
interested. Thanks,
--
Zhanyong
Zhanyong Wan (λx.x x)
> 2009/1/21 Alexander Demin <ade...@gmail.com>:
>>
>> Unfortunately "print_time" is not declared in the headers. Is this
>> only for the trunk?
>
> Uh, I guess we forgot to declare it. You can declare it yourself, but
> it's better to declare it in gtest.h. Would you like to submit a
> patch for review? See the DevGuide wiki for instructions if you are
> interested. Thanks,
While you are at it, perhaps you could add declarations for other
missing flags as well?
--
Zhanyong
Alexander Demin
Alexander
Alexander Demin
Alexander
Alexander Demin
housemaister
seems you uploaded the patch with wrong "SVN Base" (it says
http://svn.python.org/view/*checkout*/python/trunk/).
Side by-side-diff and commenting does not work.
Stefan.
Zhanyong Wan (λx.x x)
2009/1/22 housemaister <housem...@gmail.com>:
> Hi Alexander,
>
> seems you uploaded the patch with wrong "SVN Base" (it says
> http://svn.python.org/view/*checkout*/python/trunk/).
> Side by-side-diff and commenting does not work.
Yes, please check out gtest and upload the patch from gtest's own SVN check-out.
Also, have you signed the CLA yet? I cannot seem to find your record
at this time. Thanks,
--
Zhanyong
Alexander Demin
Ok, I'll try submit again. I was confused a bit because the submit procedure is a bit iffy.
Alexander
Alexander Demin
Alexander
Alexander Demin
-- http://codereview.appspot.com/12499
I was wondering when I need to change my patch to satisfy the review
(for example, http://codereview.appspot.com/12483) do I need to submit
brand new patch with new id (as I've done in http://codereview.appspot.com/12499)
or I can modify the already created one?
Alexander
On Jan 22, 10:41 pm, Alexander Demin <ade...@gmail.com> wrote:
> I've re-submitted the patch tohttp://codereview.appspot.com/12483using
>
> Alexander
>
> On Thu, Jan 22, 2009 at 8:44 PM, Alexander Demin <ade...@gmail.com> wrote:
> > I've signed the CLA recently.
>
> > Ok, I'll try submit again. I was confused a bit because the submit
> > procedure is a bit iffy.
>
> > Alexander
>
> > On Thu, Jan 22, 2009 at 5:11 PM, Zhanyong Wan (λx.x x) <w...@google.com>wrote:
>
> >> Alexander,
>
Zhanyong Wan (λx.x x)
>
> There is the next submit including all changes according to the review
> -- http://codereview.appspot.com/12499
>
> I was wondering when I need to change my patch to satisfy the review
> (for example, http://codereview.appspot.com/12483) do I need to submit
> brand new patch with new id (as I've done in http://codereview.appspot.com/12499)
> or I can modify the already created one?
Thanks. Could you please re-submit it to issue 12483 ('upload.py -i
12483')? This allows the reviewers to easily diff two patches and see
what has changed since the last time.
--
Zhanyong
Alexander Demin
By the way, does upload.py support proxy? Unfortunately I have to use using http/ftp proxy on work and that's why I have to do submits at home ;-)
Alexander
Zhanyong Wan (λx.x x)
> Great, I've re-submit it to issue 12483 as you mentioned and re-asked for
> the review.
Thanks!
> By the way, does upload.py support proxy? Unfortunately I have to use using
> http/ftp proxy on work and that's why I have to do submits at home ;-)
The people who created the tool can best answer this question. Do you
want to post it at http://groups.google.com/group/codereview-discuss ?
--
Zhanyong