Logging properties and classes

[Luca]

I tried to recompile a current project upgrading my dependencies from 2.6.1 to 2.7.0-SNAPSHOT, but I had a lot of problem due to missing properties and classes regarding the GWT logging subsystem.

It's a problem of the SNAPSHOT or we need to rework the logging ?

What about external libraries (like Errai) that extensively use logging ?

Thanks.

[Jens]

GWT 2.7 cleaned up logging a bit so you or any library that does more than just inheriting Logging.gwt.xml would need to check its configuration and maybe update it a bit when upgrading to 2.7.

In general FirebugLogHandler and NullLoggingPopup classes have been removed and the corresponding GWT properties as well.

-- J.

[Luca]

Well, not really a bit.......

Being a 2.x I would expect not to have API compatibility broken, and also if is not really a problem for my own code (some hours of work), I use some external framework that I don't control.

I think I cannot upgrade.

[Andrei Korzhevskii]

I don't think that removing FirebugLogHandler and NullLoggingPopup should be a problem for anyone, hardly anyone used that.

Can you post exact error output here?

[Luca]

Sure, updated snapshots and "mvn install":

[INFO] --- gwt-maven-plugin:2.7.0-SNAPSHOT:compile (default) @ xxxx ---

[INFO] auto discovered modules 

[INFO] Loading inherited module 'xxxxx'

[INFO]    Loading inherited module 'org.jboss.errai.common.ErraiCommon'

[INFO]       Loading inherited module 'org.jboss.errai.common.Logging'

[INFO]          [ERROR] Line 7: Property 'gwt.logging.popupHandler' not found

As you can see the property is not defined, I think that 2.7 should be retro-compatible.

[Andrei Korzhevskii]

Thanks for response!

Is it the only error you experience in gwt 2.7.0-snapshot?

Would you mind posting an issue to https://code.google.com/p/google-web-toolkit/issues/list ?

[Luca]

I don't know if it's the only one, the build stop at this first error, and I don't want to try a toy application, but a real one.

I'll fill an issue.

Thanks.

[Jens]

[INFO] --- gwt-maven-plugin:2.7.0-SNAPSHOT:compile (default) @ xxxx ---

[INFO] auto discovered modules 

[INFO] Loading inherited module 'xxxxx'

[INFO]    Loading inherited module 'org.jboss.errai.common.ErraiCommon'

[INFO]       Loading inherited module 'org.jboss.errai.common.Logging'

[INFO]          [ERROR] Line 7: Property 'gwt.logging.popupHandler' not found

As you can see the property is not defined, I think that 2.7 should be retro-compatible.

The equivalent to gwt.logging.popupHandler is now gwt.logging.hasWidgetsHandler. I think for the time being you could workaround your issue by using something like the following (untested) in your gwt.xml file:

<define-property name="gwt.logging.popupHandler" values="ENABLED, DISABLED"/>

<set-property name="gwt.logging.popupHandler" value="DISABLED" /> <!-- default -->

<set-property name="gwt.logging.popupHandler" value="ENABLED">

  <when-property-is name="gwt.logging.hasWidgetsHandler" value="ENABLED" />

</set-property>

That way you could change your own gwt.xml files to use gwt.logging.hasWidgetsHandler if needed because that is what GWT will support in the future. However you still have the legacy gwt.logging.popupHandler property defined for libraries that haven't been updated yet.

Maybe GWT 2.7 could add such a snippet in its own gwt.xml file but in GWT 3.0 it will probably be removed again.

-- J.

[Thomas Broyer]

On Tuesday, September 30, 2014 11:28:12 AM UTC+2, Luca wrote:

Well, not really a bit.......

Being a 2.x I would expect not to have API compatibility broken,

GWT does not follow SemVer.

But I agree we should probably have those 2 properties defined in 2.7 even if they're never used, and remove them in 3.0. Could you file an issue?

I'm not so sure about the classes though…

FYI, the commit that changed it all: https://gwt.googlesource.com/gwt/+/de218e819bd3d0b9818fe40c34999f4fa192e4fc%5E%21/

And if you want a list of all breaking API changes between 2.6 and 2.7: https://gwt.googlesource.com/gwt/+/master/tools/api-checker/config/gwt26_27userApi.conf#147

[Ümit Seren]

Funny I came accross the same issue today (Errai-Bus and GWT-2.7.0-SNAPSHOT). 

I filed two issues in the JIRA issue tracker for the Errai project (https://issues.jboss.org/browse/ERRAI-798 and https://issues.jboss.org/browse/ERRAI-799)

You need two workarounds: 

1.) Add the logging properties to your gwt.xml file:

<define-property name="gwt.logging.popupHandler" values="ENABLED, DISABLED" />

    <define-property name="gwt.logging.firebugHandler" values="ENABLED, DISABLED" />

2.) Creat a com.google.gwt.logging.client package and the FirebugLogHandler class that was removed in 2.7.0

[Luca]

Not for me, after that I got error in "de/barop/gwt/client/HistoryImplPushState.java", inherited from Errai.