SafeHtml and SafeStyles

[Deyan Atanasov]

Hi, I am trying to implement SafeHtml with some parameters in the HTML
style atribute:
Example:

@Template("<div style=\"{0}\"><div style=
\"position:absolute;display:none;"
+ "\"></div><div>{1}</div></div>")
SafeHtml unsorted(SafeCSSWidth imageWidth, String text);

My SafeCSSWidth class implements SafeStyles, according to the contract
but the GWT compiler still outputs:
[INFO] Generating method body for unsorted()
[INFO] [WARN] Template with variable in CSS
attribute context: The template code generator cannot guarantee HTML-
safety of the template -- please inspect manually or use SafeStyle
s to specify arguments in a CSS attribute context
[INFO] Compiling 1 permutation
[INFO] Compiling permutation 0...

I am using GWT 2.3.0.
Any suggestions ?

[Thomas Broyer]

Have a look at the SafeStylesUtils and SafeStylesBuilder; and change your "imageWidth" argument to SafeStyles (where's that SafeCSSWidth coming from?!)

See http://google-web-toolkit.googlecode.com/svn/javadoc/2.3/com/google/gwt/safecss/shared/SafeStyles.html

[Joseph Lust]

@Template("<div style=\"{0}\"><div style=\"position:absolute;display:none;"\></div><div>{1}</div></div>")

SafeHtml unsorted(SafeStyles imageWidthStyle, SafeHtml text); 

double width = 34.34d;

SafeStyles imageWidthStyle = SafeStylesUtils.fromTrustedString("width:"+width+"px;");

SafeHtml text = SafeHtmlUtils.fromString("blah");

unsorted( imageWidthStyle, text ); // call your template

That is how I'd do it. I had to fix some warnings to this end this morning for some code, so I had to look this usage up. Hope it helps.

Sincerely,

Joseph

[Thomas Broyer]

And when GWT 2.5 will be out the door:

SafeStyles imageWidthStyle = SafeStylesUtils.forWidth(width, Unit.PX);

[Joseph Lust]

I look forward to it since writing string literals for CSS properties seems silly in this day and age.

Joe