Can someone mentor me through my first push to Gerrit?

[Richard Wallis]

I'm trying to submit a fix for an issue I raised with the GWT Scheduler. https://code.google.com/p/google-web-toolkit/issues/detail?id=8838

It's a very simple change since it only modifies one static variable.

So far I've managed to check the project out and build it.

I've signed the contributor agreement.

I've made my change and checked that everything still builds ok.

I've committed my changes locally.

But when I push my changes I get internal server error: The remote connection hang up unexpectedly.

Any one able to walk me through this?

[Jens]

So you have done everything that is mentioned in [1] including the initial Gerrit setup (obtaining Http password, setup .netrc and install git commit hook)?

[1] http://gwtproject.gquery.org/makinggwtbetter.html#submittingpatches

-- J.

[Richard Wallis]

Hi Jens,

It's 9:30pm where I am, so I might stop replying for 8 hours suddenly.

I've setup and stored the http password (I assume this also covers .netrc though I'm using a windows password manager that I use for my other git projects.)

I'm on Windows and have no idea how to setup the git commit hook.  Google search has been unhelpful on this issue.

Thanks

Richard

--
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-co...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/c389cb58-ff3d-47b2-ba33-6ce297886ef5%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

[Jens]

I'm on Windows and have no idea how to setup the git commit hook.  Google search has been unhelpful on this issue.

In your GWT checkout directory you place the commit hook inside .git/hooks/ (.git already exists but you may need to create the hooks directory).

Once you have done that and you commit something in GWT this commit hook will automatically append a change-id line to your commit message. That change-id line is used by Gerrit. If your commit does not have such a line then Gerrit will most likely deny the git push.

-- J.

[Richard Wallis]

thanks I'll give it a try now.  Was looking for hooks in the git install dir.

--

You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-co...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/b1fea124-b7fc-4626-b1fe-1ac579c48472%40googlegroups.com.

[Richard Wallis]

Copied the commit-msg file into the hooks dir.

Still get same error:

Internal server error

fatal: The remote end hung up unexpectedly

[Jens]

You probably need to fix your commit as you have setup the commit hook after you have done your commit. Make sure your commit has the Change-Id line.

If your commit message looks correct and your password manager works then I have no idea why it shouldn't work. Maybe others can chime in to help you.

-- J.

[Richard Wallis]

I rolled back after adding the hook and did the whole commit over.

But I don't think the commit hook is working, at least there's no extra messages for the commit command.

From a brief look at the hook it seems to use awk which isn't available on Windows.

Anyway I'll see if I can get awk installed some how and try again.  If it doesn't work I'll bug everyone again tomorrow.

--

You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-co...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/a5d2ac8b-cde4-4f2a-b638-a6dcd7d96e0e%40googlegroups.com.

[Richard Wallis]

Just checked and the Change-Id is being generated and added.

I'm still getting the internal server error.  It happens right at the end of the push after everything's been uploaded.

Anyone have any ideas?

[Richard Wallis]

Anyone able to help me through this today?

[Julien Dramaix]

Could you copy paste the command that you use to push to gerrit and the output ?

To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAEqaEVjAJ4q%2Bb9zgM6s--ynuXOcCMqN5Wpb72_3wiorHKUKG-A%40mail.gmail.com.

[Richard Wallis]

Thanks Julien,

My push follows and I've included my commit message as well to show that the Change-Id is added correctly.

Z:\gwtsource\trunk>git push origin HEAD:refs/for/master

Counting objects: 22, done.

Delta compression using up to 8 threads.

Compressing objects: 100% (10/10), done.

Writing objects: 100% (11/11), 892 bytes | 0 bytes/s, done.

Total 11 (delta 7), reused 0 (delta 0)

remote: error: Internal server error

fatal: The remote end hung up unexpectedly

fatal: The remote end hung up unexpectedly

Z:\gwtsource\trunk>git log --pretty=full

commit 5a3daf001f28c70ee6b91ae5f9d02ca76a91b9b5

Author: Richard Wallis <rdwa...@gmail.com>

Commit: Richard Wallis <rdwa...@gmail.com>

    Issue 8838. Reduce SchedulerImpl.TIME_SLICE from 100ms to 8ms

    Change-Id: I11aedfb096f727401cea09d906301f09688ec4c6

To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CABb_3%3D5bVC0TYP-3ri03gznV_Sj07vgqRUbOP63_t-i%3DctR3-g%40mail.gmail.com.

[Thomas Broyer]

I really think something's wrong on the server.

Daniel, would you mind pinging the team at Google responsible for googlesource.com? (Shawn?)

Richard, you might want to report the issue at https://groups.google.com/d/forum/repo-discuss to try reaching the same team through other means.

To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscribe@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/a5d2ac8b-cde4-4f2a-b638-a6dcd7d96e0e%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscribe@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAEqaEVjAJ4q%2Bb9zgM6s--ynuXOcCMqN5Wpb72_3wiorHKUKG-A%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscribe@googlegroups.com.

[Richard Wallis]

Thanks Thomas, I've posted the issue at repo-discuss it should show up once it's been moderated.

To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-co...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/00f29422-e447-4495-994d-34f4b59c5f33%40googlegroups.com.

[Richard Wallis]

Anyone able to help me with my push?

I'm still getting the same error after 2 days and there is no reply from the repo-discuss group.

I'm trying to change the value of one static final variable.  It shouldn't be too hard.

[Julien Dramaix]

Could you copy paste your git config for the repository:

 more .git/config

Just to be sure that everything is correctly configured on your side.

To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAEqaEVjSQs6ALH0MHEppOH4TMHudqqDH6cDQ%2BDv8YDNL7qxhww%40mail.gmail.com.

[Richard Wallis]

Thanks Julien, I haven't modified this since I checked out the source on Sunday:

[core]

repositoryformatversion = 0

filemode = false

bare = false

logallrefupdates = true

symlinks = false

ignorecase = true

hideDotFiles = dotGitOnly

[remote "origin"]

url = https://gwt.googlesource.com/gwt

fetch = +refs/heads/master:refs/remotes/origin/master

[branch "master"]

remote = origin

merge = refs/heads/master

To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CABb_3%3D7cWuALax3NnZ9CXsKtK%2B_R-4w5-rieJMxHB0h%3DkyYEiQ%40mail.gmail.com.

[Richard Wallis]

This still isn't working this morning.  I get that this is my first commit. Most likely there's something misconfigured on my side.  

But I can't diagnose a Gerrit internal server error from my machine.  Is no one with access to the logs subscribed to this group?  It'll take 3 minutes to let me know what the error's stack trace is.

[Daniel Kurka]

Hi Richard,

I emailed the internal team to help with this. I'll update this thread once I hear back from them.

-Daniel

To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAEqaEVgZFQpin%3D4W9a1BUOjX%3D2AEcbaFu0zMgnDCvS89ShPbjQ%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--

Google Germany GmbH

Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Katherine Stephens

[Richard Wallis]

As suspected the internal server error was my fault, I'd created a shallow clone because the full clone takes me more than an hour.

Thanks for everyone's help with this.

To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CALLujiqVNtS7-Ro1b8iSYrtRwJc7vBvzr1vYK0%2BScH_MjD_STQ%40mail.gmail.com.